[v8.x backport] test: remove --harmony-sharedarraybuffer usage#21717
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. PR-URL: nodejs#16343 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
addaleax approved these changes Jul 9, 2018
Member
addaleax commented Jul 9, 2018
Member
addaleax commented Jul 11, 2018
Landed in 4be5252 |
addaleax pushed a commit that referenced this pull request Jul 11, 2018
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. Backport-PR-URL: #21717 PR-URL: #16343 Reviewed-By: Anna Henningsen <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. Backport-PR-URL: #21717 PR-URL: #16343 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.
PR-URL: #16343
Reviewed-By: Jeremiah Senkpiel [email protected]
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Anatoli Papirovski [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Timothy Gu [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBackport, as requested, of #16343