tools: auto fix custom eslint rule for prefer-assert-methods.js

[shobhitchittora]

This adds eslint fixer for auto-fixing the usage of assert operators. Also adding fileoverview for the perfer-assert-methods.js file.

For example the fixer change this assert(obj.value !== 9); to assert.notStrictEqual(obj.value, 9);

Refs: #16636

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines
• modify tests

Affected core subsystem(s)

Tools

[shobhitchittora]

Hi @apapirovski. Can you also review this one? Thanks in advance.

[BridgeAR]

In general LGTM but it should be extended to assert.ok() as assert() is actually just the alias.

[addaleax]

CI: https://ci.nodejs.org/job/node-test-commit/14472/

[apapirovski]

ping @shobhitchittora — would you like to follow up on this? There's a bit of feedback here from @BridgeAR.

[shobhitchittora]

@apapirovski@BridgeAR extended for assert.ok. Please review.

[BridgeAR]

I would not prefer assert.ok over assert. Both should be fine out of my perspective.

[shobhitchittora]

I'm a bit confused here. What did you mean when you said extend for assert.ok()?

[BridgeAR]

In general assert() should be treated identical to assert.ok(). And I meant the tests should be extended to test for both. Before I commented there were only tests for assert().

[shobhitchittora]

Thanks for clarifying this. I'll revert the added invalid test for assert(val).

[shobhitchittora]

Done.

[apapirovski]

I could be wrong but I think the idea was that assert(foo != bar) should yield the same as assert.ok(foo != bar). Since the former is an alias for the latter. That is, they should both report an error.

(I realize that might be modifying the current rule and is somewhat outside of the scope of the original work.)

[BridgeAR]

That would indeed be nice but I guess it is best to keep that for a separate PR and I am actually about to improve the assert message for cases like that in #17581

[shobhitchittora]

@BridgeAR@apapirovski Updated the PR as per the new implementation by @cjihrig.

[BridgeAR]

Mini-CI (enough for this test): https://ci.nodejs.org/job/node-test-commit-light/149/

[BridgeAR]

Landed in 2d6912a