v9.6.0 proposal#18902
Merged
v9.6.0 proposal #18902
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, writeQueueSize is never used in C++ and barely used within JS. Instead of constantly updating the value on the JS object, create a getter that will retrieve the most up-to-date value from C++. For the vast majority of cases though, create a new prop on Socket.prototype[kLastWriteQueueSize] using a Symbol. Use this to track the current write size, entirely in JS land. Backport-PR-URL: #18084 PR-URL: #17650 Reviewed-By: Anna Henningsen <[email protected]>
The TLS implementation previously kept a separate buffer for incoming pieces of data, into which buffers were copied before they were up for writing. This removes this buffer, and replaces it with a simple list of `uv_buf_t`s: - The previous implementation copied all incoming data into that buffer, both allocating new storage and wasting time with copy operations. Node’s streams/net implementation already has to make sure that the allocated memory stays fresh until the write is finished, since that is what libuv streams rely on anyway. - The fact that a separate kind of buffer, `crypto::NodeBIO` was used, was confusing: These `BIO` instances are only used to communicate with openssl’s streams system otherwise, whereas this one was purely for internal memory management. - The name `clear_in_` was not very helpful. PR-URL: #17883 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Original commit message: Introduce ScriptOrModule and HostDefinedOptions This patch introduces a new container type ScriptOrModule which provides the name and the host defined options of the script/module. This patch also introduces a new PrimitivesArray that can hold Primitive values, which the embedder can use to store metadata. The HostDefinedOptions is passed to V8 through the ScriptOrigin, and passed back to the embedder through HostImportModuleDynamically for module loading. Bug: v8:5785, v8:6658, v8:6683 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I56c26fc9a680b273ac0a6691e5ad75f15b8dc80a Reviewed-on: https://chromium-review.googlesource.com/622158 Reviewed-by: Adam Klein <[email protected]> Reviewed-by: Georg Neis <[email protected]> Commit-Queue: Sathya Gunasekaran <[email protected]> Cr-Commit-Position: refs/heads/master@{#47724} Backport-PR-URL: #17823 PR-URL: #16889 Refs: v8/v8@dbfe4a4 Refs: #15713 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This is an initial implementation to support dynamic import in both scripts and modules. It's off by default since support for dynamic import is still flagged in V8. Without setting the V8 flag, this code won't be executed. This initial version does not support importing into vm contexts. Backport-PR-URL: #17823 PR-URL: #15713 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Bradley Farias <[email protected]>
currently if you want to use dynamic import you must use both the `--experimental-modules` and the `--harmony-dynamic-imports` flags. Chrome is currently shipping dynamic import unflagged, the flag only remains in V8 to guard embedders who have not set the appropriate callback from throwing an unhandled rejection when the feature is used. As such it is reasonable to enable the flag by default for `--experimental-modules` Backport-PR-URL: #17823 PR-URL: #18387 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw only if acorn is found in the deps directory. Also changed the deprecation test for v9.x: common.expectWarning was failing because the required deps now throw ReferenceErrors when not properly called internally in the right order. Bacport-PR-URL: #18077 PR-URL: #17848Fixes: #17148 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: #18465 PR-URL: #18111 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Backport-PR-URL: #18487 PR-URL: #17403 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit. Backport-PR-URL: #18487 PR-URL: #17456 Refs: #12956 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fix an issue where error is never emitted on the original EventEmitter in situations where a listener for error does exist. Refactor to eliminate unnecessary try/catch/finally block. Backport-PR-URL: #18487 PR-URL: #17588 Refs: #17403 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #16874 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Bradley Farias <[email protected]>
PR-URL: #18596 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Replace some repeated full links with concise ones and bottom references. PR-URL: #18213 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes #16931 PR-URL: #17687 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Reworked rebase of PR #17360 with feedback PR-URL: #18194Fixes: #17340 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Ensure `common.tmpDir` exists before trying to chdir into it. Fixes a "ENOENT: no such file or directory, uv_chdir" error when the temporary directory is removed before running the test. PR-URL: #17407 Reviewed-By: Richard Lau <[email protected]>
V8's behavior changed in c3bd741efd. Top-level variables in a module are no longer context-allocated by default. PR-URL: #18312 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Long ago, V8 was much faster switching on string lengths than values. That is no longer the case, so we can simplify a couple of methods. PR-URL: #18351 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Move the majority of C++ domain-related code into JS land by introducing a top level domain callback which handles entering & exiting the domain. Move the rest of the domain necessities into their own file that creates an internal binding, to avoid exposing domain-related code on the process object. Modify an existing test slightly to better test domain-related code. PR-URL: #18291 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
- remove TODOs: the one about defaults has been addressed, and the one about testing is a work item that doesn't belong in a doc. - add some background information Fixes: #7843 PR-URL: #16939 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18445 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
PR-URL: #18376 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fixes: #18434 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This is described as being a doc-only deprecation subset. Refs: #18417 PR-URL: #18433 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]>
It makes more sense to provide instructions on how to update the PR branch before instructions on pushing the commit. PR-URL: #18355 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
PR-URL: #18460Fixes: #18459 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: #18468 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Welcome Gibson to the TSC! PR-URL: #18481 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18414 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This brings the behaviour in line with the documentation. PR-URL: #16944 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
1. Fixer for crypto-check.js 2. Extends tests PR-URL: #16647 Refs: #16636 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1. Adds fixer method 2. Extends test PR-URL: #16646 Refs: #16636 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #18739 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Currenlty when configuring --debug-http2 /test/parallel/test-http2-getpackedsettings.js will segment fault: $ out/Debug/node test/parallel/test-http2-getpackedsettings.js Segmentation fault: 11 This is happening because the settings is created with the Environment in PackSettings: Http2Session::Http2Settings settings(env); This will cause the session to be set to nullptr. When the init function is later called the expanded DEBUG_HTTP2SESSION macro will cause the segment fault when the session is dereferenced. PR-URL: #18815 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: #18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #18872 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18873 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #11135 PR-URL: #18843 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
PR-URL: #18845 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #18849 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #18850 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This fixes a bug in the CPU profiler where some ticks were attributed to the wrong file. Original commit message: [cpu-profiler] Fix script name when recording inlining info Use the script name from the shared function info to create an inline entry. Otherwise functions are attributed to the wrong file in the CpuProfileNode. See googleapis/cloud-profiler-nodejs#89 Bug: v8:7203, v8:7241 Change-Id: I8ea31943741770e6611275a9c93375922b934547 Reviewed-on: https://chromium-review.googlesource.com/848093 Reviewed-by: Jaroslav Sevcik <[email protected]> Commit-Queue: Franziska Hinkelmann <[email protected]> Cr-Commit-Position: refs/heads/master@{#50339} Refs: v8/v8@76c3ac5 PR-URL: #18298 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Note that the CI run for the exercise can be minimal. PR-URL: #18846 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18847 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
* Sync format schemes with the current doc state. * Lowercase primitive types. * Fix typos and unify the style. * Remove tautological info. PR-URL: #18874 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Notable changes: * async_hooks: - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 - rename PromiseWrap.parentId to PromiseWrap.isChainedPromise (Ali Ijaz Sheikh) #18633 * deps: - update node-inspect to 1.11.3 (Jan Krems) #18354 - ICU 60.2 bump (Steven R. Loomis) #17687 - Introduce ScriptOrModule and HostDefinedOptions to V8 (Jan Krems) #16889 * http: - add options to http.createServer() for `IncomingMessage` and `ServerReponse` (Peter Marton) #15752 * http2: - add http fallback options to .createServer (Peter Marton) #15752 * https: - Adds the remaining options from tls.createSecureContext() to the string generated by Agent#getName(). This allows https.request() to accept the options and generate unique sockets appropriately. (Jeff Principe) #16402 * inspector: - --inspect-brk for es modules (Guy Bedford) #18194 * lib: - allow process kill by signal number (Sam Roberts) #16944 * module: - enable dynamic import (Myles Borins) #18387 - dynamic import is now supported (Jan Krems) #15713 * napi: - add methods to open/close callback scope (Michael Dawson) #18089 * src: - allow --perf-(basic-)?prof in NODE_OPTIONS (Leko) #17600 * vm: - add support for es modules (Gus Caplan) #17560 PR-URL: #18902
MylesBorinsforce-pushed the v9.6.0-proposal branch from 924ee96 to 9f810bdCompareMylesBorinsforce-pushed the v9.6.0-proposal branch from 9f810bd to cb18511CompareContributorAuthor
I accidentally folded in a file I shouldn't have... DUHHH. The last CI / CITGM run... everything looks good CI: https://ci.nodejs.org/job/node-test-pull-request/13318/ CITGM-NO-BUILD for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/240/ I've bumped the release date to the 22nd as I need to kick off the build again, plan to release later this evening, likely after midnight edit: one more citgm for comparison https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1304/ |
Contributor
ofrobots commented Feb 22, 2018
Re: |
cjihrig approved these changes Feb 22, 2018
MylesBorins added a commit that referenced this pull request Feb 22, 2018
Notable changes: * async_hooks: - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 - rename PromiseWrap.parentId to PromiseWrap.isChainedPromise (Ali Ijaz Sheikh) #18633 * deps: - update node-inspect to 1.11.3 (Jan Krems) #18354 - ICU 60.2 bump (Steven R. Loomis) #17687 - Introduce ScriptOrModule and HostDefinedOptions to V8 (Jan Krems) #16889 * http: - add options to http.createServer() for `IncomingMessage` and `ServerReponse` (Peter Marton) #15752 * http2: - add http fallback options to .createServer (Peter Marton) #15752 * https: - Adds the remaining options from tls.createSecureContext() to the string generated by Agent#getName(). This allows https.request() to accept the options and generate unique sockets appropriately. (Jeff Principe) #16402 * inspector: - --inspect-brk for es modules (Guy Bedford) #18194 * lib: - allow process kill by signal number (Sam Roberts) #16944 * module: - enable dynamic import (Myles Borins) #18387 - dynamic import is now supported (Jan Krems) #15713 * napi: - add methods to open/close callback scope (Michael Dawson) #18089 * src: - allow --perf-(basic-)?prof in NODE_OPTIONS (Leko) #17600 * vm: - add support for es modules (Gus Caplan) #17560 PR-URL: #18902
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Notable changes: * async_hooks: - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) nodejs#18513 - rename PromiseWrap.parentId to PromiseWrap.isChainedPromise (Ali Ijaz Sheikh) nodejs#18633 * deps: - update node-inspect to 1.11.3 (Jan Krems) nodejs#18354 - ICU 60.2 bump (Steven R. Loomis) nodejs#17687 - Introduce ScriptOrModule and HostDefinedOptions to V8 (Jan Krems) nodejs#16889 * http: - add options to http.createServer() for `IncomingMessage` and `ServerReponse` (Peter Marton) nodejs#15752 * http2: - add http fallback options to .createServer (Peter Marton) nodejs#15752 * https: - Adds the remaining options from tls.createSecureContext() to the string generated by Agent#getName(). This allows https.request() to accept the options and generate unique sockets appropriately. (Jeff Principe) nodejs#16402 * inspector: - --inspect-brk for es modules (Guy Bedford) nodejs#18194 * lib: - allow process kill by signal number (Sam Roberts) nodejs#16944 * module: - enable dynamic import (Myles Borins) nodejs#18387 - dynamic import is now supported (Jan Krems) nodejs#15713 * napi: - add methods to open/close callback scope (Michael Dawson) nodejs#18089 * src: - allow --perf-(basic-)?prof in NODE_OPTIONS (Leko) nodejs#17600 * vm: - add support for es modules (Gus Caplan) nodejs#17560 PR-URL: nodejs#18902Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2018-02-22, Version 9.6.0 (Current), @MylesBorins
Notable Changes
IncomingMessageandServerReponse(Peter Marton) #15752Commits
7f5334e243] - (SEMVER-MINOR)async_hooks: deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #185138e39c3bfd6] - (SEMVER-MINOR)async_hooks: rename PromiseWrap.parentId (Ali Ijaz Sheikh) #186330865d11c08] - async_hooks: clean up comments (Ali Ijaz Sheikh) #184674d78eb8663] - benchmark: improve compare output (Ruben Bridgewater) #18597ffbad8350e] - benchmark: spread operator benchmark (James M Snell) #184429ae513a7de] - benchmark: shorten config name in http benchmark (Joyee Cheung) #18452d469a06ace] - benchmark: cut down http benchmark run time (Joyee Cheung) #183799c125825a9] - benchmark: refactor (Ruben Bridgewater) #18320f0186704cd] - benchmark: (timers) refactor (Ruben Bridgewater) #1832028156e16d1] - benchmark: (http(2)) refactor (Ruben Bridgewater) #18320076b3d9b0a] - benchmark: (es) refactor (Ruben Bridgewater) #1832076cb958975] - benchmark: (url) refactor (Ruben Bridgewater) #183200851822b87] - benchmark: (crypto) refactor (Ruben Bridgewater) #18320cb13c7c653] - benchmark: (buffer) refactor (Ruben Bridgewater) #183209acf7545f0] - benchmark: (assert) refactor (Ruben Bridgewater) #183207da01f43fd] - benchmark: fix variables not being set (Ruben Bridgewater) #183204a5d7d4248] - benchmark: fix platform in basename-win32 (Ruben Bridgewater) #18320f3ab106750] - buffer: remove obsolete NaN check (Ruben Bridgewater) #18744c38576e526] - buffer: simplify check size in assertSize (Mihail Bodrov) #18665080368b5d0] - build: no longer have v8-debug.h as dependency. (Yang Guo) #1867715db2969fe] - build: do not suppress output in make doc-only (Joyee Cheung) #18507c642e229da] - build: add doc linting when runnningmake lint(Camilo Gonzalez) #18472be5c293d73] - build: allow x86_64 as a dest_cpu alias for x64 (Rod Vagg) #180529c6bb5f386] - build: add cflags for OpenBSD, remove stray comma. (Aaron Bieber) #184482c7de9df50] - build,win: replace run-python subroutine with single find_python call (Nikolai Vavilov) #1862191f2cf9297] - child_process: fix stdio sockets creation (Santiago Gimeno) #18701a893b42791] - crypto: use non-deprecated v8::Object::Set (Daniel Bevenius) #174822a2f6be6e7] - deps: V8: backport 76c3ac5 from upstream (Ali Ijaz Sheikh) #18298442903fb1b] - deps: update node-inspect to 1.11.3 (Jan Krems) #183549e7f8633b6] - deps: ICU 60.2 bump (Steven R. Loomis) #1768711566fe532] - deps: cherry-pick dbfe4a49d8 from upstream V8 (Jan Krems) #168892bec889b6a] - doc: fix nits in tools/doc/README.md (Vse Mozhet Byt) #188749589955c87] - doc: fix minor grammar/typographical issues in onboarding.md (Rich Trott) #1884758ecdd42e2] - doc: update onboarding.md for faster exercise completion (Rich Trott) #188469c53060dbb] - doc: improved documentation for fs.unlink() (dustinnewman98) #18843183c18cdb1] - doc: fix broken link in pull-requests.md (Justin Lee) #18873e9766e3618] - doc: fix typo in http2.md (Vse Mozhet Byt) #18872ab4365ed04] - doc: refactor manpage to use mdoc(7) macros (Alhadis) #18559253c030dac] - doc: mark accessing IPC channel fd as undefined (Bartosz Sosnowski) #17545f18c8013a1] - doc: fix minor typos in GOVERNANCE.md (Rich Trott) #18829d1ff8fa87a] - doc: add Yihong Wang to collaborators (Yihong Wang) #18824eb9d0bacb8] - doc: warn against concurrent http2stream.respondWithFD (Anna Henningsen) #18762c569f701b2] - doc: activateno-multiple-empty-linesrule (Ruben Bridgewater) #1874700b629b3bb] - doc: note that linting is required in releases.md (Gibson Fahnestock) #187760fc33fb282] - doc: remove extra space in README.md (Matheus Marchini) #188229bec493510] - doc: update crypo Certficate class. (Antoine AMARA) #1872117d4dd5cce] - doc: move Fedor to TSC Emeritus (Myles Borins) #1875292ed0710da] - doc: add mmarchini to collaborators (Matheus Marchini) #18740b5073a0744] - doc: mark NAPI_AUTO_LENGTH as code (Tobias Nießen) #186973cfb313e8e] - doc: add error check to fs example (Evan Lucas) #18681876e186573] - doc: fix exporting a function example (Aonghus O Nia) #186617b377cffdb] - doc: add history for url.parse (Steven) #186854981e98889] - doc: fix links to Style Guide and CPP Style Guide (Justin Lee) #18683af977dbf49] - doc: add devsnek to collaborators (Gus Caplan) #18679f0f01039b4] - doc: fix links in YAML metadata of assert.md (Vse Mozhet Byt) #18670832e0522eb] - doc: add missing meta for createCipheriv (Tobias Nießen) #18651affddd372a] - doc: fix description of createDecipheriv (Tobias Nießen) #186514722004900] - doc: fix MDN links to avoid redirections (Vse Mozhet Byt) #18631e7508e5fcd] - doc: fix link in https.md (Vse Mozhet Byt) #18630dc4da22220] - doc: be more explicit in the sypnosis (Tim O. Peters) #1797754391548d0] - doc: add missing "changes" key in YAML comment (Luigi Pinca) #186057241fa0fbd] - doc: fix typo in http2.md (Vse Mozhet Byt) #186027a432c1af3] - doc: update onboarding-extras (Gus Caplan) #18545c18d958750] - doc: modify the return value of request.write() (陈刚) #18526e8a75ee113] - doc: fix typo in n-api.md (Vse Mozhet Byt) #185904f521c7896] - doc: add introduce about cli options (Weijia Wang) #184754dea9e03d6] - doc: small typo in n-api.md (iskore) #185556256d70916] - doc: add section for strategic initiatives (Michael Dawson) #171045f0b3431e1] - doc: remove usage of you in n-api doc (Michael Dawson) #185282418c86c1e] - doc: expand on promises and async_hooks (Ali Ijaz Sheikh) #18540a7ad003e37] - doc: shell option for the execFile and execFileSync functions (jvelezpo) #18237dae86b3edb] - doc: improve http.request documentation (Guangcong Luo) #18289ffc8e8eb40] - doc: remove removed apis from http2 docs (Kelvin Jin) #1843925a7bdece5] - doc: streamline README intro (Rich Trott) #1848358003d4ddf] - doc: move Brian White to TSC Emeriti list (Rich Trott) #1848274a823c788] - doc: improve stream documentation (陈刚) #18375ae372f0e3d] - doc: linkify missing types (Vse Mozhet Byt) #1844422093abbc8] - doc: add Gibson Fahnestock to TSC (Rich Trott) #1848161d4e1d207] - doc: reorder section on updating PR branch (Ali Ijaz Sheikh) #183558a627b17a4] - doc: add pending-deprecation to COLLABORATOR_GUIDE (Сковорода Никита Андреевич) #18433b76e111ee4] - doc: fix manpage warnings (Roman Reiss)b841abc328] - doc: warn about GCM authenticity (Tobias Nießen) #183762d968ca0d5] - doc: Update tools/icu/README.md (Steven R. Loomis) #169398c6dc62dc4] - doc: dedupe links (Vse Mozhet Byt) #182136b1a40e914] - doc: capitalize non-primitive types (Vse Mozhet Byt) #1811144bf0f4f12] - domain: further abstract usage in C++ (Anatoli Papirovski) #1829135471bcfdf] - domain: fix error emit handling (Anatoli Papirovski) #1758828edc1db99] - events: use Reflect.apply (Anatoli Papirovski) #174563ae5cf205f] - events: move domain handling from events to domain (vdeturckheim) #174034601bfd261] - fs: remove useless comments which duplicate names of variables (Sergey Golovin) #187395b75572494] - fs: replace magic numbers by named constants (Sergey Golovin) #1875735ce3a8931] - fs: make URL paths no longer experimental (James M Snell) #1859134f49343ee] - fs: fix stack overflow in fs.readdirSync (Joyee Cheung) #186476ce8b24c6d] - http: simplify checkInvalidHeaderChar (Seth Brenith) #18381c247cb02a1] - (SEMVER-MINOR)http: add options to http.createServer() (Peter Marton) #15752935eac189d] - http: remove domain specific code (Anatoli Papirovski) #184778b2a272772] - http: process headers after setting up agent (Rod Vagg) #16568d76403985f] - http: switch on string values (Seth Brenith) #183515e5276b418] - http2: use_finalinstead ofon('finish')(Anna Henningsen) #18609c0d6945f4c] - http2: add req and res options to server creation (Peter Marton) #155607806c51f30] - (SEMVER-MINOR)http2: add http fallback options to .createServer (Peter Marton) #157527c682f2fd0] - (SEMVER-MINOR)https: add extra options to Agent#getName() (Jeff Principe) #1640274051c64aa] - inspector: --inspect-brk for es modules (Guy Bedford) #181941fc0a416e0] - (SEMVER-MINOR)lib: allow process kill by signal number (Sam Roberts) #1694447dfe29d32] - lib: replaceevalwithvm.runInThisContext(Myles Borins) #1862316aeddda24] - lib: switch to Number.isNaN (Ruben Bridgewater) #187441557d93a2b] - lib: set process.execPath on OpenBSD (Aaron Bieber) #185430a97e1d2c0] - lib: provide proper deprecation code (Ruben Bridgewater) #1869451a8e1d2d8] - lib: remove debugger dead code (Qingyan Li) #18426650ec2d8f1] - lib: extract validation functions (Timothy O. Peters) #184211fd1395ee9] - lib,doc: revert format name to cjs over commonjs (Guy Bedford) #18596cb36b6733c] - loader: fix up src, loader: return promises from link #18394 (Gus Caplan) #18509afc87c22d0] - module: refactor loader (Gus Caplan) #16874d89f310127] - module: enable dynamic import flag for esmodules (Myles Borins) #1838700d5422c43] - module: Set dynamic import callback (Jan Krems) #157139c818cfa83] - n-api: remove extra reference from test (Gabriel Schulhof) #185424bf8b6a62d] - (SEMVER-MINOR)n-api: add methods to open/close callback scope (Michael Dawson) #18089d2581120da] - n-api: wrap control flow macro in do/while (Ben Noordhuis) #18532ae8f5db1b1] - n-api: implement wrapping using private properties (Gabriel Schulhof) #18311a07cd06e6c] - n-api: change assert ok check to notStrictEqual. (Aaron Kau) #18414f54659cbc8] - net: simplify net.Socket#end() (Anna Henningsen) #187086ed4e690e4] - net: remove Socket.prototoype.read (Anna Henningsen) #18568958f5eda9a] - net: remove redundant code from _writeGeneric() (Luigi Pinca) #1842925ce45825f] - net,src: refactor writeQueueSize tracking (Anatoli Papirovski) #1765080c614298c] - path: replace duplicate conditions by functions (Sergey Golovin) #186935331454a30] - path: replace "magic" numbers by readable constants (Sergey Golovin) #186540a47b98f04] - perf_hooks: add warning when too many entries in the timeline (James M Snell) #18087cec3d1ea80] - process: fix reading zero-length env vars on win32 (Anna Henningsen) #1846336332eba27] - readline: use Date.now() and move test to parallel (Anatoli Papirovski) #18563e47fd4c69a] - src: add nullptr check for session in DEBUG macro (Daniel Bevenius) #18815de3231c13a] - src: factor out some common vm functions (Timothy Gu) #17560a258f6b5ce] - src: flatten ContextifyContext (Gus Caplan) #17560a7419d0902] - src: replace var for let / const. (alejandro estrada) #18649d190c9a41e] - src: add "icu::" prefix before ICU symbols (Steven R. Loomis)3ec3c329c6] - src: fix crypto.pbkdf2 callback error argument (BufoViridis) #18458464df6d9b5] - (SEMVER-MINOR)src: allow --perf-(basic-)?prof in NODE_OPTIONS (Leko) #1760043956e9600] - src: free memory before re-setting URLHost value (Ivan Filenko) #18357272fd2e334] - src: fix vector subscript out of range (Anatoli Papirovski) #1846064c36d31b6] - src, lib: return promises from link (Gus Caplan) #18394ba46103291] - stream: fix misleading error message (Luigi Pinca) #1860427532f4e9a] - stream: cleanup() when unpiping all streams. (陈刚) #18266a4cc0fb1b6] - stream: delete unused code (陈刚) #18278450f5f43bc] - stream: delete redundant code (陈刚) #18145560f657957] - stream: delete redundant code (陈刚) #181459af1e4b286] - string_decoder: reset decoder on end (Justin Ridgewell) #1849410f92d1f73] - test: http2 client settings invalid callback (Trivikram) #18850baf1acc94f] - test: http2 client ping errors (Trivikram) #1884962c9992cfc] - test: http2 client operations after destroy (Trivikram) #1884572484e5d7f] - test: refactor parallel/test-tls-pause (juggernaut451) #18714b4510f7016] - test: refactor stream-*-constructor-set-methods (Luigi Pinca) #18817ff43209c5a] - test: refactor parallel/test-tls-0-dns-altname (juggernaut451) #188030eead8cbab] - test: add common.skipIfEslintMissing (Myles Borins) #18807840a2ea8e3] - test: fix warnings in addon tests (Ali Ijaz Sheikh) #188107874cb0f3c] - test: refactor parallel/test-tls-addca (juggernaut451) #18798b3b5ac5169] - test: refactor of test-tls-over-http-tunnel (juggernaut451) #18784849f5c31c8] - test: make tls test more rigorous (Ben Noordhuis) #18792cf10a94b48] - test: reduce benchmark test run time (juggernaut451) #187878b5ca482fa] - test: try to connect after server was closed (Leko) #1825775c691b788] - test: wrap countdown callback in common.mustCall (Bamieh) #18506ed55374b98] - test: update a few tests to work on OpenBSD (Aaron Bieber) #185437e75a78c5a] - test: add lib path env when node_shared=true (Yihong Wang) #18626d6786d2110] - test: add multiline repl input regression test (cjihrig) #1871818c493397f] - test: remove unnecessary timer (cjihrig) #187195b88cb747e] - test: add crypto check to test-benchmark-tls (Daniel Bevenius) #187246c041638c3] - test: fix missing param in benchmark-timers (Anatoli Papirovski) #187343362ae79df] - test: fix and improve error message (Kevin Caulfield) #18449e9c9200aba] - test: add useful info to error msg and refactor (Chin Huang) #1854172d71594bd] - test: fix flaky repl-timeout-throw (Santiago Gimeno) #186922089814b67] - test: properly tag anonymous namespaces (Michael Dawson) #18583a667ac1665] - test: fix flaky timers-block-eventloop test (Anatoli Papirovski) #18567f3e6c7636a] - test: refactor test-http-abort-before-end (cjihrig) #185080277993f49] - test: improve error message output (Bhavani Shankar) #1849830a233cfce] - test: fix flaky test-http2-session-unref (Anatoli Papirovski) #18589ef2d9c2c54] - test: do not check TXT content in test-dns-any (Joyee Cheung) #1854710dc25df83] - test: improve tests for test-http-url.parse (Weijia Wang) #18523a13fbdd4c3] - test: remove destructor from node_test_fixture (Daniel Bevenius) #1852452aeb2a070] - test: verify the shell option works properly on execFile (jvelezpo) #183840d390f7bdf] - test: add test for tls benchmarks (Anatoli Papirovski) #18489da0d776593] - test: mark test-inspector-stop-profile-after-done flaky (Myles Borins) #184918c9b41aaee] - test: show pending exception error in napi tests (Ben Wilcox) #18413f6c9a2bc47] - test: speed up parallel/test-tls-session-cache (Anna Henningsen) #184246b74064e65] - test: fix flaky test-http-dns-error (Bryan English) #16534eb252527e5] - test: move tmpdir to submodule of common (Rich Trott) #17856b5267a6926] - test: force context allocation in test module (Yang Guo) #18312cc8091448b] - test: fix flaky cluster unix socket test (Ben Noordhuis) #1740719abee149d] - test: fix a bug & lint issues in inspector-helper (Anatoli Papirovski) #18293b5752ee6a4] - test: fix require-deps-deprecation for installed deps (Benjamin Zaslavsky) #1784815754e62e1] - test,benchmark,doc: enable dot-notation rule (Ruben Bridgewater) #18749146e8ac83a] - timers: remove domain specific code (Anatoli Papirovski) #18477f3244a12fd] - tls: tls_wrap causes debug assert in vector (Kyle Farnung) #188303725d4ccea] - tls: remove cleartext input data queue (Anna Henningsen) #1788311dea2860c] - tools: custom eslint autofix for inspector-check.js (Shobhit Chittora) #16646f48062f317] - tools: auto fix custom crypto-check eslint rule (Shobhit Chittora) #16647ae3398aad6] - tools: fix eslint isRequired (Ruben Bridgewater) #18729a33dc81b2f] - tools: add fixer for prefer-assert-iferror.js (Shobhit Chittora) #16648aabbdc84c2] - tools: add .mjs linting for Windows (Vse Mozhet Byt) #18569e00bb1657f] - tools: non-Ascii linter for /lib only (Sarat Addepalli) #180434f4bfbecbf] - tools: auto fix custom eslint rule (Shobhit Chittora) #16652ef45bb4305] - tools: fix icu readme lint error (Anatoli Papirovski) #184451767ef06f3] - url: simplify constructor URLSearchParams. Remove needless check null (Mihail Bodrov) #1870007e4ba2519] - url: simplify loop in parser (Tobias Nießen) #18468c8f729f7a3] - v8: add missing ',' in OpenBSD's 'sources' section. (Aaron Bieber) #1844802afdbc5c6] - vm: flip Module#link's signature (Gus Caplan) #184711cbd76a100] - vm: add modules (Gus Caplan) #17560c34e2f4fc5] - win, build: fix intl-none option (Birunthan Mohanathas) #18292