Skip to content

tls: tls_wrap causes debug assert in vector#18830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kfarnung merged 1 commit into from
Feb 19, 2018
Merged

tls: tls_wrap causes debug assert in vector #18830

kfarnung merged 1 commit into from
Feb 19, 2018

Conversation

@kfarnung
Copy link
Contributor

@kfarnungkfarnung commented Feb 17, 2018

When using a debug build (on Windows specifically) the error case for
tls_wrap causes an assert to fire because the index being passed is
outside the bounds of the vector.

The fix is to switch to iterators.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tls

@kfarnungkfarnung self-assigned this Feb 17, 2018
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Feb 17, 2018
@kfarnung
Copy link
ContributorAuthor

kfarnung commented Feb 17, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13233/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2018
@kfarnung
tls: tls_wrap causes debug assert in vector
de0ed84
When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: nodejs#18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@kfarnungkfarnung merged commit de0ed84 into nodejs:masterFeb 19, 2018
@kfarnung
Copy link
ContributorAuthor

kfarnung commented Feb 19, 2018

Landed in de0ed84

@kfarnungkfarnung deleted the tlswrap branch February 19, 2018 21:02
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@kfarnung@MylesBorins
tls: tls_wrap causes debug assert in vector
e05ecaa
When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: #18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@kfarnung@MylesBorins
tls: tls_wrap causes debug assert in vector
f3244a1
When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: #18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@kfarnung@MylesBorins
tls: tls_wrap causes debug assert in vector
f8f1423
When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: #18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@kfarnung@MayaLekova
tls: tls_wrap causes debug assert in vector
e85ae12
When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: nodejs#18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

@JungMinuJungMinuJungMinu approved these changes

Assignees

@kfarnungkfarnung

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kfarnung@jasnell@addaleax@cjihrig@JungMinu@MylesBorins@BridgeAR@nodejs-github-bot