Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
test,benchmark,doc: enable dot-notation rule#18749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This enables the eslint dot-notation rule for all code instead of only in /lib.
MemberAuthor
BridgeAR commented Feb 13, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
lpinca approved these changes Feb 13, 2018
Member
lpinca commented Feb 13, 2018 via email
Yes, I was wrong. GitHub sends notifications too soon :) …On Tue, Feb 13, 2018 at 9:55 PM, Anatoli Papirovski < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/common/inspector-helper.js <#18749 (comment)>: > @@ -168,9 +168,7 @@ class InspectorSession{reject(message.error)} else{if (message.method === 'Debugger.scriptParsed'){- const script = message['params']; - const scriptId = script['scriptId']; - const url = script['url']; + const{scriptId, url } = message.params; I think it is, no? message['params']['scriptId'] and message['params']['url']. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18749 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYIR2juHK9HRKgzN-vnit1RXpG2Q-Pqks5tUfbHgaJpZM4SDOjo> . |
jasnell approved these changes Feb 13, 2018
mmarchini approved these changes Feb 15, 2018
MemberAuthor
BridgeAR commented Feb 16, 2018
CI before landing https://ci.nodejs.org/job/node-test-commit-light/271/ |
MemberAuthor
BridgeAR commented Feb 16, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Landed in 463d1a4 |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: nodejs#18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
yhwang pushed a commit to yhwang/node that referenced this pull request Feb 22, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: nodejs#18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: nodejs#18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: #18749 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. toolsIssues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the eslint dot-notation rule for all code instead of
only in /lib.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,doc,benchmark