async_hooks: clean up comments#18467
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added async_hooks 
AndreasMadsen approved these changes Jan 30, 2018
Member
AndreasMadsen left a comment
AndreasMadsen left a comment There was a problem hiding this comment.
LGTM and huge thanks from me.
cjihrig approved these changes Jan 31, 2018
jasnell approved these changes Jan 31, 2018
BridgeAR approved these changes Feb 1, 2018
BridgeAR added author ready 
Member
BridgeAR commented Feb 1, 2018
Member
AndreasMadsen commented Feb 1, 2018
@BridgeAR What are the rules for fast-tracing PRs? I don't see any reasons for fast-tracking this as it doesn't solve any critical bugs (also 48 hours have already passed). |
Member
BridgeAR commented Feb 1, 2018
@AndreasMadsen on the Node Collaborator Summit we spoke about it and we could not find really hard rules for it. But trivial changes like doc things that already got multiple looking good are a good example. And due to the label others can disagree while the label is there (the label is stuck for a while as well). |
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: nodejs@83e5215 Ref: nodejs@0784b04 PR-URL: nodejs#18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
ofrobotsforce-pushed the async-hooks-comments branch from ea6771b to ad94be8Compare
ContributorAuthor
ofrobots commented Feb 1, 2018
Thanks. Landed in ad94be8. I intentionally wanted to keep this open for the full 2 days. AsyncHooks can be a fairly complex and subtle topic and the idea was to make sure there is nothing missing in the understanding of the semantics. |
addaleax removed the author ready MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Contributor
MylesBorins commented Mar 20, 2018
Landed on 8.x, please lmk if this shouldn't have |
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: nodejs@83e5215 Ref: nodejs@0784b04 PR-URL: nodejs#18467 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some of the recent work, some of the comments were no longer
representative of the code, or were otherwise unclear. This commit
fixes some obvious issues I found.
Ref: 83e5215
Ref: 0784b04
Checklist
Affected core subsystem(s)
async_hooks