Skip to content

test: refactor stream-*-constructor-set-methods#18817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lpinca wants to merge 2 commits into from
Closed

test: refactor stream-*-constructor-set-methods #18817

lpinca wants to merge 2 commits into from

Conversation

@lpinca
Copy link
Member

@lpincalpinca commented Feb 16, 2018

  • Use common.mustCall() to ensure that callbacks are called.
  • Remove no longer needed variables.
  • Remove unnecessary process.on('exit') usage.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@lpinca
test: refactor stream-*-constructor-set-methods
01e7a71
- Use `common.mustCall()` to ensure that callbacks are called. - Remove no longer needed variables. - Remove unnecessary `process.on('exit')` usage.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 16, 2018
@lpincalpinca added the stream Issues and PRs related to the stream subsystem. label Feb 16, 2018
@lpinca
Copy link
MemberAuthor

lpinca commented Feb 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13203/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
maclover7
maclover7 approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@maclover7maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 17, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 17, 2018

Landed in 33103e9 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 17, 2018
@lpinca@BridgeAR
test: refactor stream-*-constructor-set-methods
33103e9
- Use `common.mustCall()` to ensure that callbacks are called. - Remove no longer needed variables. - Remove unnecessary `process.on('exit')` usage. PR-URL: nodejs#18817 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@lpincalpinca deleted the refactor/constructor-set-methods branch February 17, 2018 14:37
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
test: refactor stream-*-constructor-set-methods
7812654
- Use `common.mustCall()` to ensure that callbacks are called. - Remove no longer needed variables. - Remove unnecessary `process.on('exit')` usage. PR-URL: #18817 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
test: refactor stream-*-constructor-set-methods
b4510f7
- Use `common.mustCall()` to ensure that callbacks are called. - Remove no longer needed variables. - Remove unnecessary `process.on('exit')` usage. PR-URL: #18817 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
test: refactor stream-*-constructor-set-methods
fa0b987
- Use `common.mustCall()` to ensure that callbacks are called. - Remove no longer needed variables. - Remove unnecessary `process.on('exit')` usage. PR-URL: #18817 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@lpinca@MayaLekova
test: refactor stream-*-constructor-set-methods
b2884c3
- Use `common.mustCall()` to ensure that callbacks are called. - Remove no longer needed variables. - Remove unnecessary `process.on('exit')` usage. PR-URL: nodejs#18817 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+1 more reviewer

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.streamIssues and PRs related to the stream subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lpinca@BridgeAR@jasnell@cjihrig@maclover7@MylesBorins@nodejs-github-bot