Skip to content

Conversation

@kjin
Copy link
Contributor

@kjinkjin commented Jan 29, 2018

  • Removed references to removed socketError event
  • Removed second definition of Http2Session#close (as far as I could tell in the implementation, close no longer accepts an options object)
  • Add parameter types for ClientHttp2Session'altsvc' event
  • Re-ordered event names in Http2SecureServer to be alphabetical and added 'session' event (from Http2Server)
Checklist
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jan 29, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018
@BridgeAR
Copy link
Member

@jasnell
Copy link
Member

Looks like some linting issues.

@kjin
Copy link
ContributorAuthor

kjin commented Feb 3, 2018

Oops, forgot to remove a ```. Thanks!

@addaleax
Copy link
Member

Landed in 71b15e8

@addaleaxaddaleax closed this Feb 4, 2018
addaleax pushed a commit that referenced this pull request Feb 4, 2018
PR-URL: #18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

kjin added a commit to kjin/node that referenced this pull request May 1, 2018
PR-URL: nodejs#18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
Backport-PR-URL: #20456 PR-URL: #18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18439 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@kjin@BridgeAR@jasnell@addaleax@MylesBorins@apapirovski@nodejs-github-bot