Skip to content

buffer: simplify check size in assertSize#18665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Connormiha wants to merge 1 commit into from
Closed

buffer: simplify check size in assertSize #18665

Connormiha wants to merge 1 commit into from

Conversation

@Connormiha
Copy link
Contributor

@ConnormihaConnormiha commented Feb 8, 2018•
edited
Loading

Removed needless else if.

Checklist
Affected core subsystem(s)

buffer

@nodejs-github-botnodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Feb 8, 2018
@BridgeARBridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 9, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 9, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/13052/

@BridgeAR
Copy link
Member

BridgeAR commented Feb 10, 2018

Landed in d1e80e7 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 10, 2018
@Connormiha@BridgeAR
buffer: simplify check size in assertSize
d1e80e7
PR-URL: nodejs#18665 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha@MylesBorins
buffer: simplify check size in assertSize
2bbc5dd
PR-URL: #18665 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha@MylesBorins
buffer: simplify check size in assertSize
415e452
PR-URL: #18665 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha@MylesBorins
buffer: simplify check size in assertSize
a958121
PR-URL: #18665 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@Connormiha@MylesBorins
buffer: simplify check size in assertSize
c38576e
PR-URL: #18665 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 13, 2018

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Connormiha@MayaLekova
buffer: simplify check size in assertSize
377e173
PR-URL: nodejs#18665 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@daynindaynindaynin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@Connormiha@BridgeAR@MylesBorins@apapirovski@jasnell@daynin@targos@cjihrig@joyeecheung@BethGriggs@nodejs-github-bot