Fixed broken links to Style Guide and CPP Style Guide#18683
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vsemozhetbyt approved these changes Feb 9, 2018
vsemozhetbyt added the fast-track 
joyeecheung approved these changes Feb 9, 2018
Member
joyeecheung left a comment
joyeecheung left a comment There was a problem hiding this comment.
Yeah...the style guide should probably go into doc/guides, although that can be resolved/discussed in another PR
BridgeAR approved these changes Feb 9, 2018
BridgeAR added the author ready 
Member
BridgeAR commented Feb 9, 2018
richardlau approved these changes Feb 10, 2018
cjihrig approved these changes Feb 10, 2018
vsemozhetbyt pushed a commit that referenced this pull request Feb 10, 2018
PR-URL: #18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
vsemozhetbyt commented Feb 10, 2018
Landed in 37c88f0 |
jasnell approved these changes Feb 10, 2018
Contributor
vsemozhetbyt commented Feb 10, 2018
Not closing for now to investigate nodejs/node-core-utils#170 |
Member
BridgeAR commented Feb 10, 2018
Seems like the issue gets addressed. I am closing this therefore as there is nothing more to do. |
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
PR-URL: #18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18683 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Mar 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed the broken links in
pull-requests.md, but I'm not convinced that the Style Guides are located in the right places to begin with. Thoughts?Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)