Skip to content

build: no longer have v8-debug.h as dependency.#18677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hashseed wants to merge 1 commit into from
Closed

build: no longer have v8-debug.h as dependency. #18677

hashseed wants to merge 1 commit into from

Conversation

@hashseed
Copy link
Member

@hashseedhashseed commented Feb 9, 2018

This is no longer necessary, and V8 is planning to remove the file altogether.

Ref: #18643

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 9, 2018
@BridgeARBridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 9, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 9, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/13071/

@BridgeAR
Copy link
Member

BridgeAR commented Feb 10, 2018

Landed in 4a1a4bf 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 10, 2018
@hashseed@BridgeAR
build: no longer have v8-debug.h as dependency.
4a1a4bf
Ref: nodejs#18643 PR-URL: nodejs#18677 Refs: nodejs#18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@hashseed@MylesBorins
build: no longer have v8-debug.h as dependency.
a53067c
Ref: #18643 PR-URL: #18677 Refs: #18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@hashseed@MylesBorins
build: no longer have v8-debug.h as dependency.
4eb31cf
Ref: #18643 PR-URL: #18677 Refs: #18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@hashseed@MylesBorins
build: no longer have v8-debug.h as dependency.
d2f7468
Ref: #18643 PR-URL: #18677 Refs: #18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@hashseed@MylesBorins
build: no longer have v8-debug.h as dependency.
080368b
Ref: #18643 PR-URL: #18677 Refs: #18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 13, 2018
@hashseed@MylesBorins
build: no longer have v8-debug.h as dependency.
88d3028
Ref: #18643 PR-URL: #18677 Refs: #18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@hashseedhashseed deleted the remove-v8-debug-from-master branch April 16, 2018 09:08
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@hashseed@MayaLekova
build: no longer have v8-debug.h as dependency.
5ba4a09
Ref: nodejs#18643 PR-URL: nodejs#18677 Refs: nodejs#18643 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hashseed@BridgeAR@bnoordhuis@jasnell@cjihrig@tniessen@MylesBorins@nodejs-github-bot