events: use Reflect.apply#17456
Closed
events: use Reflect.apply #17456
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
apapirovski added domain 
nodejs-github-bot added domain 
TimothyGu approved these changes Dec 4, 2017
cjihrig approved these changes Dec 4, 2017
targos approved these changes Dec 4, 2017
ContributorAuthor
apapirovski commented Dec 4, 2017
lpinca approved these changes Dec 5, 2017
jasnell approved these changes Dec 5, 2017
BridgeAR approved these changes Dec 6, 2017
Member
BridgeAR commented Dec 6, 2017
I would say this does not require 48 hours. |
Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit.
apapirovskiforce-pushed the patch-events-reflect-apply branch from 73d2844 to 0587724CompareContributorAuthor
Missed a spot (+ rebased), have to run the CI again. |
ContributorAuthor
apapirovski commented Dec 6, 2017
Landed in f5eb803 |
apapirovski added a commit that referenced this pull request Dec 6, 2017
Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit. PR-URL: #17456 Refs: #12956 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Contributor
MylesBorins commented Dec 12, 2017
Should this be backported to |
apapirovski added a commit to apapirovski/node that referenced this pull request Jan 31, 2018
Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit. PR-URL: nodejs#17456 Refs: nodejs#12956 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit. Backport-PR-URL: #18487 PR-URL: #17456 Refs: #12956 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Contributor
MylesBorins commented Feb 20, 2018
Setting this as don't land for LTS, please let me know if this should be changed |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of callback bound apply, instead use the standard
Reflect.apply. This is both safer and appears to offer a slight performance benefit. Perhaps due to not having to search the prototype tree? No clue tbh but I'm seeing 3-5% difference with substantial significance.Refs: #12956
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
domain, events