test: fix issues in inspector-helper#18293
Conversation
apapirovski added the fast-track 
apapirovski commented Jan 22, 2018
apapirovski commented Jan 22, 2018
I think |
guybedford left a comment
guybedford left a comment There was a problem hiding this comment.
Thanks for the quick fix on this, apologies for the noise.
guybedford commented Jan 22, 2018
@apapirovski it seems I messed up a sync to an older commit... I can PR the fix or we can revert for now as well. |
guybedford dismissed their stale reviewI'm going to rather PR the fix with the test cases as well
apapirovski commented Jan 22, 2018
@guybedford I should have a fix shortly. I'll include in this PR. |
apapirovski changed the title guybedford commented Jan 22, 2018
#18295 should cover the test cases here too. |
Will land this when CI is done since it has approvals. |
guybedford left a comment
guybedford left a comment There was a problem hiding this comment.
Test case fix looks good to me, pending CI checks.
guybedford commented Jan 22, 2018
Seems like the Windows tests have unstable here. If you think that could have been introduced by this I'd be open to a revert. |
apapirovski commented Jan 22, 2018
@guybedford I'm very certain those have been unstable for a while. I think we can land this. |
guybedford commented Jan 22, 2018
👍 sounds good to me. |
apapirovski commented Jan 22, 2018
Landing... |
apapirovski commented Jan 22, 2018
Landed in a3555d0 |
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
MylesBorins commented Mar 20, 2018
Should this be backported to |
PR-URL: nodejs#18293 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
6 participants
Fixes linting issues introduced in #18194
This needs to be fast-tracked.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test