net: remove Socket.prototoype.read#18568
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Unused since 34b535f.
apapirovski approved these changes Feb 4, 2018
hiroppy approved these changes Feb 4, 2018
danbev approved these changes Feb 5, 2018
Member
joyeecheung commented Feb 5, 2018
CITGM against master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1255/ |
lpinca approved these changes Feb 5, 2018
evanlucas approved these changes Feb 5, 2018
jasnell approved these changes Feb 5, 2018
BridgeAR added arm 
BridgeAR approved these changes Feb 6, 2018
Contributor
apapirovski commented Feb 8, 2018
Landed in ef78a1e |
apapirovski pushed a commit that referenced this pull request Feb 8, 2018
Unused since 34b535f. PR-URL: #18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Unused since 34b535f. PR-URL: #18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Unused since 34b535f. PR-URL: #18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Unused since 34b535f. PR-URL: #18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Unused since 34b535f. PR-URL: #18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
gibfahn commented Apr 13, 2018
Should this land on v6.x and v8.x? @addaleax I know you added the labels, just wanted to double-check as it seems (at first glance) that there's a possibility of this breaking someone who was expecting that function to be there. |
MemberAuthor
addaleax commented Apr 13, 2018
@gibfahn The function is inherited from |
BethGriggs pushed a commit that referenced this pull request Apr 13, 2018
Unused since 34b535f. PR-URL: #18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Unused since 34b535f. PR-URL: nodejs#18568 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused since 34b535f.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
net
CI: https://ci.nodejs.org/job/node-test-commit/15943/