Skip to content

stream: fix misleading error message#18604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lpinca wants to merge 1 commit into from
Closed

stream: fix misleading error message #18604

lpinca wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

@lpincalpinca commented Feb 6, 2018

The method to implement is _write not _transform.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

@lpinca
stream: fix misleading error message
117ed15
The method to implement is `_write` not `_transform`.
@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Feb 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 6, 2018

@lpinca please always trigger a CI after creating a PR.

@lpinca
Copy link
MemberAuthor

lpinca commented Feb 6, 2018•
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/12971/
CI: https://ci.nodejs.org/job/node-test-pull-request/13000/

@BridgeARBridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 7, 2018
@mcollina
Copy link
Member

mcollina commented Feb 8, 2018

Landing.

mcollina
mcollina approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Feb 8, 2018

Landed as e9b5b4f

@mcollinamcollina closed this Feb 8, 2018
mcollina pushed a commit that referenced this pull request Feb 8, 2018
@lpinca@mcollina
stream: fix misleading error message
e9b5b4f
The method to implement is `_write` not `_transform`. PR-URL: #18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@lpincalpinca deleted the fix/error-message branch February 8, 2018 13:27
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
stream: fix misleading error message
8dc7713
The method to implement is `_write` not `_transform`. PR-URL: #18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
stream: fix misleading error message
a75f071
The method to implement is `_write` not `_transform`. PR-URL: #18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
stream: fix misleading error message
8215f67
The method to implement is `_write` not `_transform`. PR-URL: #18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@lpinca@MylesBorins
stream: fix misleading error message
ba46103
The method to implement is `_write` not `_transform`. PR-URL: #18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@lpinca@MayaLekova
stream: fix misleading error message
47e2b6d
The method to implement is `_write` not `_transform`. PR-URL: nodejs#18604 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+1 more reviewer

@apapirovskiapapirovskiapapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lpinca@BridgeAR@mcollina@apapirovski@addaleax@cjihrig@gibfahn@nodejs-github-bot