Skip to content

string_decoder: reset decoder on end#18494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jridgewell wants to merge 1 commit into from
Closed

string_decoder: reset decoder on end #18494

jridgewell wants to merge 1 commit into from

Conversation

@jridgewell
Copy link
Contributor

@jridgewelljridgewell commented Feb 1, 2018•
edited
Loading

This resets the StringDecoder's state after calling #end. Further
writes to the decoder will act as if it were a brand new instance,
allowing simple reuse.

This supersedes #16594, which seems abandoned.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

string_decoder

Refs: #16594
Fixes: #16564

@jridgewell
string_decoder: reset decoder on end
4cc5226
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. Refs: nodejs#16594Fixes: nodejs#16564
@nodejs-github-botnodejs-github-bot added the string_decoder Issues and PRs related to the string_decoder subsystem. label Feb 1, 2018
TimothyGu
TimothyGu approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@TimothyGuTimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much prefer this PR over the approach taken by #16594. LGTM.

@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/12874/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

Is anyone against fast tracking?

@addaleax
Copy link
Member

addaleax commented Feb 1, 2018

Is anyone against fast tracking?

Tbh, I would like that, because this PR was opened while I was still running the benchmarks for a major refactor of string_decoder. :)

addaleax
addaleax approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@addaleaxaddaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2018
@addaleax
Copy link
Member

addaleax commented Feb 2, 2018

Landed in d2a6110, thanks for the PR! 🎉

@addaleaxaddaleax closed this Feb 2, 2018
addaleax pushed a commit that referenced this pull request Feb 2, 2018
@jridgewell@addaleax
string_decoder: reset decoder on end
d2a6110
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@jridgewelljridgewell deleted the string_decoder-end branch February 2, 2018 19:36
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2018
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@jridgewell@MylesBorins
string_decoder: reset decoder on end
9a8bc9a
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@jridgewell@MylesBorins
string_decoder: reset decoder on end
4ff735e
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@jridgewell@MylesBorins
string_decoder: reset decoder on end
9af1e4b
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 20, 2018

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@jridgewell@MylesBorins
string_decoder: reset decoder on end
40d4d2e
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@jridgewell@MylesBorins
string_decoder: reset decoder on end
5e86f20
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@jridgewell@MylesBorins
string_decoder: reset decoder on end
f96b0bf
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@jridgewell@MayaLekova
string_decoder: reset decoder on end
25c0ebd
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: nodejs#18494Fixes: nodejs#16564 Refs: nodejs#16594 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@thefourtheyethefourtheyethefourtheye approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.string_decoderIssues and PRs related to the string_decoder subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jridgewell@BridgeAR@addaleax@MylesBorins@thefourtheye@TimothyGu@nodejs-github-bot