net: track bytesWritten in C++ land#19551
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ This was referenced Mar 24, 2018
MemberAuthor
addaleax commented Mar 24, 2018
Added a regression test for #19562 + a bit more cleanup to make sure |
MemberAuthor
MemberAuthor
addaleax commented Mar 27, 2018
jasnell approved these changes Mar 27, 2018
addaleax added the author ready MemberAuthor
addaleax commented Mar 27, 2018
Re-building Linux CI: https://ci.nodejs.org/job/node-test-commit-linux/17383/ |
addaleax removed the author ready 
Move tracking of `socket.bytesWritten` to C++ land. This makes it easier to provide this functionality for all `StreamBase` instances, and in particular should keep working when they have been 'consumed' in C++ in some way (e.g. for the network sockets that are underlying to TLS or HTTP2 streams). Also, this parallels `socket.bytesRead` a lot more now.
Simply always tell the caller how many bytes were written, rather than letting them track it. In the case of writing a string, also keep track of the bytes written by the earlier `DoTryWrite()`. Refs: nodejs#19562
addaleax added the author ready MemberAuthor
addaleax commented Mar 29, 2018
MemberAuthor
addaleax commented Mar 30, 2018
Landed in abc8786...b7cfd27 |
addaleax added a commit that referenced this pull request Mar 30, 2018
Move tracking of `socket.bytesWritten` to C++ land. This makes it easier to provide this functionality for all `StreamBase` instances, and in particular should keep working when they have been 'consumed' in C++ in some way (e.g. for the network sockets that are underlying to TLS or HTTP2 streams). Also, this parallels `socket.bytesRead` a lot more now. PR-URL: #19551 Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Mar 30, 2018
Fixes: #19562 PR-URL: #19551 Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Mar 30, 2018
Simply always tell the caller how many bytes were written, rather than letting them track it. In the case of writing a string, also keep track of the bytes written by the earlier `DoTryWrite()`. Refs: #19562 PR-URL: #19551 Reviewed-By: James M Snell <[email protected]>
2 tasks
Member
targos commented Apr 2, 2018
Should this be backported to |
targos added backport-requested-v9.x and removed author ready BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Move tracking of `socket.bytesWritten` to C++ land. This makes it easier to provide this functionality for all `StreamBase` instances, and in particular should keep working when they have been 'consumed' in C++ in some way (e.g. for the network sockets that are underlying to TLS or HTTP2 streams). Also, this parallels `socket.bytesRead` a lot more now. PR-URL: nodejs#19551 Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Fixes: nodejs#19562 PR-URL: nodejs#19551 Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Simply always tell the caller how many bytes were written, rather than letting them track it. In the case of writing a string, also keep track of the bytes written by the earlier `DoTryWrite()`. Refs: nodejs#19562 PR-URL: nodejs#19551 Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Jun 29, 2018
Fixes: #19562 PR-URL: #19551 Reviewed-By: James M Snell <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
Fixes: #19562 PR-URL: #19551 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tracking of
socket.bytesWrittento C++ land.This makes it easier to provide this functionality for all
StreamBaseinstances, and in particular should keep workingwhen they have been 'consumed' in C++ in some way (e.g. for
the network sockets that are underlying to TLS or HTTP2 streams).
Also, this parallels
socket.bytesReada lot more now.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes