net,http2: merge write error handling & property names#19734
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: nodejs#19060
nodejs-github-bot added the lib / src 
lpinca approved these changes Apr 1, 2018
tniessen approved these changes Apr 1, 2018
jasnell approved these changes Apr 1, 2018
aks- approved these changes Apr 2, 2018
MemberAuthor
addaleax commented Apr 5, 2018
Member
lpinca commented Apr 6, 2018
BridgeAR added the author ready 
trivikr approved these changes Apr 10, 2018
MemberAuthor
addaleax commented Apr 10, 2018
MemberAuthor
addaleax commented Apr 12, 2018
Landed in 93967d0 |
addaleax added net addaleax added a commit that referenced this pull request Apr 12, 2018
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: #19060 PR-URL: #19734 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: #19060 PR-URL: #19734 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: nodejs#19060 PR-URL: nodejs#19734 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
4 tasks
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge error handling for
net.Sockets andHttp2Streams,and align the callback property names as
callback.Refs: #19060
(This has become possible after #19551)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc fyi @aks-