test: string to template literals, to include port#20889
Uh oh!
There was an error while loading. Please reload this page.
Conversation
test: string to template literals, to include port test: string to template literals, to include port
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
Thanks for working on this. Some changes are needed as otherwise the linter will complain.
| server.listen({ | ||
| port: 0, | ||
| exclusive: true | ||
| exclusive: true, |
There was a problem hiding this comment.
Nit: please remove the comma here since it's an unrelated change. Thanks!
There was a problem hiding this comment.
The comma is still here after the update. As it's not related to this PR, could you please remove it?
| worker2.on('message',function(port2){ | ||
| assert.strictEqual(port2,port2|0,'second worker could not listen'); | ||
| assert.strictEqual(port2,port2|0,`second worker could not listen on port ${port2}`); |
There was a problem hiding this comment.
This will fail the linter, unfortunately. Same above.
You could instead realign like so:
assert.strictEqual(port2,port2|0,`second worker could not listen on port ${port2}`);There was a problem hiding this comment.
The alternative would be to just remove the message altogether and instead show the default error message. That would also be fine with me.
Trott commented May 23, 2018
Trott added the author ready 
nammn commented May 25, 2018
Hey guys, do you have some tips for me to make the checks successful, as i was not changing much? |
PR-URL: #20889 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tniessen commented May 25, 2018
The failures are unrelated, CI is a bit noisy currently. Landed in 76a1feb, thank you! |
PR-URL: #20889 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
8 participants
test: string to template literals, to include port
Usage of template literals to include the port if strictEqual fails.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes