v10.3.0 proposal#21011
Merged
v10.3.0 proposal #21011
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes an incorrect example in the documentation for calling `fs.readFileSync` on a directory. The example was presumably copied from the documentation for `fs.readFile`, which has an error argument in its callback. PR-URL: #20902 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #20870 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
We are currently having issues with test-child-process-fork-net on Windows CI. Debugging is slightly hampered by the mix of `console.log()` and `console.error()` as our test runner does not interleave stdout and stderr, so the order of output is not preserved. Change the sole instance of `console.error()` to `console.log()` to improve debugability. While editing, I also took the opportunity to add capitalization and punctuation to comments (as that is a nit we see from time to time and there is a potential ESLint rule to enforce the capitalization part). PR-URL: #20873 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #20864 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
When generating an assertion error message, `filename` might be undefined, e.g. if `assert` is called in `eval`. Handle this case gracefully instead of failing with `Cannot read property 'endsWith' of undefined`. Fixes: #20847 PR-URL: #20848 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #16459 PR-URL: #20845 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add tests in parallel/test-readline-interface to increase coverage PR-URL: #20704 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #20508 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #20903 PR-URL: #20904 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #20779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #20890 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Adds mappings to uv_pipe_chmod call by adding two new options to listen call. This allows the IPC server pipe to be made readable or writable by all users. Fixes: #19154 PR-URL: #19472 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #20913 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #20190 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #20889 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This commit is to help in the effort to name all anonymous functions to help when heap debugging. The issue asked for any functions to be updated that are not on a prototype and this file contains one function that meets those needs. A previous pull request (13849) was not completed and did not meet the requirements of the issue so this PR looks to complete that. PR-URL: #20811 Refs: #8913 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This is more generally useful than just in a crypto context. PR-URL: #20885 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #20949Fixes: #20853 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
A couple entries were missing and one entry was not really relevant. PR-URL: #20316 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Remove obsolete string literals from `assert.strictEqual()` calls in test/parallel/test-stream-pip-await-drain-push-while-write.js. PR-URL: #20920 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). PR-URL: #20912Fixes: #20911 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #20883 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Original commit message: Fix default Intl language tag handling With certain ICU data bundles (such as the Node.js "small-icu"), %GetDefaultICULocale() may return a more specific language tag (e.g. "en-US") than what's available (e.g. "en"). In those cases, consider the more specific language tag supported. This CL also resolves the following Node.js issue: #15223 Bug: v8:7024 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73 Reviewed-on: https://chromium-review.googlesource.com/668350 Commit-Queue: Daniel Ehrenberg <[email protected]> Reviewed-by: Daniel Ehrenberg <[email protected]> Cr-Commit-Position: refs/heads/master@{#52716} PR-URL: #20826Fixes: #15223 Refs: v8/v8@6989b3f Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This refactors some tests to reduce the runtime of those. PR-URL: #20688 Refs: #20128 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Yang Guo <[email protected]>
Improve AssertionError message in test/parallel/test-async-wrap-pop-id-during-load.js to include the contents of stderr when the spawned process fails. Refs: https://github.com/nodejs/node/pull/20940/files#r190707951 PR-URL: #20948 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #21003 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This change introduces the CHECK_IMPLIES macro similar to its definition in v8 and replaces instances of CHECK with CHECK_IMPLIES where it seems appropriate. PR-URL: #20914 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This change introduces CHECK_NULL and CHECK_NOT_NULL macros similar to their definition in v8 and replaces instances of CHECK/CHECK_EQ/CHECK_NE with these where it seems appropriate. PR-URL: #20914 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS. PR-URL: #20926 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
This section groups type links by their home modules and sort these groups alphabetically, so `modules` types should go before the `net` types. PR-URL: #20976 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot added doc 
MylesBorinsforce-pushed the v10.3.0-proposal branch from 148c3ce to 18f2719CompareContributorAuthor
Member
mcollina commented May 29, 2018
I've added the notable-change label to #20924. It is a bad bug. |
mcollina approved these changes May 29, 2018
Member
mcollina left a comment
mcollina left a comment There was a problem hiding this comment.
rubberstamp LGTM based on the commit list
MylesBorinsforce-pushed the v10.3.0-proposal branch from 18f2719 to b68b1dfCompareMylesBorins added a commit that referenced this pull request May 29, 2018
Notable Changes: * **deps**: - upgrade npm to 6.1.0 (Rebecca Turner) #20190 * **fs**: - fix reads with pos \> 4GB (Mathias Buus) #21003 * **net**: - new option to allow IPC servers to be readable and writable by all users (Bartosz Sosnowski) #19472 * **stream**: - fix removeAllListeners() for Stream.Readable to work as expected when no arguments are passed (Kael Zhang) #20924 * **Added new collaborators** - John-David Dalton (https://github.com/jdalton) PR-URL: #21011
ContributorAuthor
MylesBorins commented May 29, 2018
Windows failure already has a PR open --> #21012 |
Member
mafintosh commented May 29, 2018
👍 AKA the "You're gonna wanna get this" release. |
Member
devsnek commented May 29, 2018
I don't know that adding the discord was a notable change in the conventional sense but bumping it up might help give people another option for support. |
The package-lock.json file is out of sync with the checked-in node_modules. `make doc-only` updates package-lock.json appropriately. PR-URL: #20970 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Notable Changes: * **deps**: - upgrade npm to 6.1.0 (Rebecca Turner) #20190 * **fs**: - fix reads with pos \> 4GB (Mathias Buus) #21003 * **net**: - new option to allow IPC servers to be readable and writable by all users (Bartosz Sosnowski) #19472 * **stream**: - fix removeAllListeners() for Stream.Readable to work as expected when no arguments are passed (Kael Zhang) #20924 * **Added new collaborators** - John-David Dalton (https://github.com/jdalton) PR-URL: #21011
MylesBorinsforce-pushed the v10.3.0-proposal branch from b68b1df to c1dae43CompareContributorAuthor
MylesBorins commented May 29, 2018
Two new failures I don't recognize
and
|
ContributorAuthor
MylesBorins commented May 29, 2018
Kicking off another CI to be safe |
ContributorAuthor
MylesBorins commented May 29, 2018
Looks like the ubuntu failure is showing up on master as well in https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1710-x64/19164/ linux one passed this time. Looking into a single citgm failure on ubuntu 1604 (spawn-wrap) and then will promote release |
MylesBorins added a commit that referenced this pull request May 29, 2018
Notable Changes: * **deps**: - upgrade npm to 6.1.0 (Rebecca Turner) #20190 * **fs**: - fix reads with pos \> 4GB (Mathias Buus) #21003 * **net**: - new option to allow IPC servers to be readable and writable by all users (Bartosz Sosnowski) #19472 * **stream**: - fix removeAllListeners() for Stream.Readable to work as expected when no arguments are passed (Kael Zhang) #20924 * **Added new collaborators** - John-David Dalton (https://github.com/jdalton) PR-URL: #21011
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2018-05-29, Version 10.3.0 (Current), @MylesBorins
Notable Changes
Commits
ea702e2812] - assert: handle undefined filename in getErrMessage (Tim Seckinger) #20848d7fed22511] - build,win: disable DLL-interface warnings (Bert Belder) #20958efc7f91354] - deps: cherry-pick 6989b3f6d7 from V8 upstream (Timothy Gu) #20826d0cdcb61fe] - (SEMVER-MINOR)deps: upgrade npm to 6.1.0 (Rebecca Turner) #20190ce13797dca] - doc: fix doc for napi_get_typedarray_info (Michael Dawson) #20747babc9da6f9] - doc: add jdalton to collaborators (John-David Dalton) #20968f0704f2407] - doc: mark Node 4 as EOL in changelog (Teddy Katz) #2092687ad9318bb] - doc: update the notable changes (Ruben Bridgewater) #20316c036cda1f5] - doc: fix outdated link FSEvents (amitbend) #209491f3eb1cc1e] - doc: fix filehandle.truncate() sample codes (Masashi Hirano) #20913819bba6d2b] - doc: removed LTS label from v4 in doc version picker (Chris Young) #20904be2a467395] - doc: fix incorrect fs.readFileSync example output (Teddy Katz) #20902bfe6dc369d] - fs: fix reads with pos > 4GB (Mathias Buus) #21003c2c3b6f434] - lib: use object destructuring for ContextifyScript (Daniel Bevenius) #20934d2bcd55fb5] - lib: remove unnecessary string interpolation (Daniel Bevenius) #20890099c6b6c5d] - meta: add link to unofficial discord (Gus Caplan) #2050845adec2616] - module: name anonymous function for debugging (Nicholas Dangles) #20811ba30d149ea] - n-api: throw when entry point is null (Gabriel Schulhof) #20779b242248188] - (SEMVER-MINOR)net: allow IPC servers be accessible by all (Bartosz Sosnowski) #19472ed9e964357] - net: remove unnecessary variables (chainhelen) #208645f9c01b646] - Revert "repl: add friendly tips about how to exit repl" (cjihrig) #20972902120a927] - src: add CHECK_NULL/CHECK_NOT_NULL macros (Tobias Nießen) #209145e69e1a51e] - src: add CHECK_IMPLIES macro (Tobias Nießen) #20914418739c021] - src: fix MallocedBuffer move assignment operator (Anna Henningsen) #20883b4519cac20] - src: move DeleteFnPtr into util.h (Anna Henningsen) #20885b0023d7bc9] - src,doc: add doc of --prof flag to help command (ohbarye) #208458f52c3fb6b] - stream: fix removeAllListeners() for Stream.Readable (Kael Zhang) #20924011235768c] - test: improve assert test hygiene (Rich Trott) #2086188f9a399d6] - test: isolate unusual assert test in its own file (Rich Trott) #20861460a5025d0] - test: fix test failure on aix (Ruben Bridgewater) #20940d09bec8a04] - test: improve error message in async-wrap test (Rich Trott) #20948460add98fb] - test: reduce runtime (Ruben Bridgewater) #2068882afb4cf7d] - test: remove message argument from strictEqual() (sagirk) #2091240e57885d4] - test: remove string literal from strictEqual (AbhimanyuVashisht) #209209bbab91479] - test: include port in assertion message (nam) #20889554ad478d4] - test: improve coverage for readline.Interface (Masashi Hirano) #20704443d60afcc] - test: use log only in test-child-process-fork-net (Rich Trott) #20873ed84b7d42f] - test: changed assert message from string literal to template literal (CoreyGMartin) #2087046e7cec7a5] - tools: fix sorting in doc/type-parser.js (Vse Mozhet Byt) #20976