Skip to content

Conversation

@amitbend
Copy link
Contributor

@amitbendamitbend commented May 24, 2018

Changed the link for FSEvents in the docs as suggested in issue #20853

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 24, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 24, 2018

Fixes: #20853

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2018
@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 8a58ec6
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request May 25, 2018
PR-URL: #20949Fixes: #20853 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request May 25, 2018
PR-URL: #20949Fixes: #20853 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request May 29, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@amitbend@vsemozhetbyt@jasnell@lpinca@cjihrig@BridgeAR@trivikr@nodejs-github-bot