doc: add jdalton to collaborators#20968
Uh oh!
There was an error while loading. Please reload this page.
Conversation
BridgeAR commented May 25, 2018
Welcome :-) |
jdalton changed the title 
jdalton commented May 25, 2018
Thank you! (I currently still need the bits toggled to be able to spin up a CI run and-or merge). |
README.md Outdated
There was a problem hiding this comment.
The lines seem to be in the wrong order) Screenshot:
vsemozhetbyt added meta 
addaleax commented May 25, 2018
@jdalton Are you being onboarded by somebody at the moment? We usually open these PRs as part of that process – not that there’s anything wrong with this PR, but I think we want to wait with merging it until that occurs? |
addaleax removed the fast-track 
BridgeAR commented May 25, 2018
@addaleax I thought these PRs are always meant to be merged by the onboarded person. If there was no onboarding, that is of course not happening. |
jdalton commented May 25, 2018
That's cool. No one has contacted me yet for onboarding (so I figured I'd get the ball rolling). |
richardlau commented May 25, 2018
I'm going to set blocked just to prevent anyone else merging (although by convention these PRs should only be merged by the onboarded person anyway). Obviously consider it unblocked when the onboarding occurs. |
jdalton commented May 28, 2018
jdalton commented May 28, 2018
Landed in bb6b605 |
PR-URL: nodejs#20968Fixes: nodejs#20828 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
gireeshpunathil commented May 28, 2018
post-closure LGTM! |
benjamingr commented May 28, 2018
Welcome aboard @jdalton ! |
PR-URL: #20968Fixes: #20828 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
16 participants
Fixes: #20828
Checklist