doc: mark Node 4 as EOL in changelog#20926
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the meta 
ContributorAuthor
not-an-aardvark commented May 24, 2018
CHANGELOG.md Outdated
Member
There was a problem hiding this comment.
Maybe End-of-life since 2018-05-01?
ContributorAuthor
There was a problem hiding this comment.
I copied this from the previous text for v0.10/v0.12, but I'm fine with changing it. What do you think?
Member
There was a problem hiding this comment.
Ah didn't spot that. I'd be fine with either.
Member
There was a problem hiding this comment.
I prefer End-of-life since 2018-05-01 but it is also ok this way.
ContributorAuthor
There was a problem hiding this comment.
I updated the message to End-of-life since 2018-05-01.
richardlau approved these changes May 24, 2018
lpinca approved these changes May 24, 2018
starkwang approved these changes May 24, 2018
BridgeAR approved these changes May 24, 2018
CHANGELOG.md Outdated
Member
There was a problem hiding this comment.
I prefer End-of-life since 2018-05-01 but it is also ok this way.
BridgeAR added the author ready 
cjihrig approved these changes May 24, 2018
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS.
not-an-aardvarkforce-pushed the mark-node-4-eol branch from 0ebdc1c to 1a866abCompareContributorAuthor
not-an-aardvark commented May 24, 2018
jasnell approved these changes May 24, 2018
trivikr approved these changes May 25, 2018
XadillaX approved these changes May 25, 2018
hiroppy approved these changes May 25, 2018
mmarchini approved these changes May 26, 2018
ContributorAuthor
not-an-aardvark commented May 26, 2018
Landed in 6d3940e |
not-an-aardvark added a commit that referenced this pull request May 26, 2018
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS. PR-URL: #20926 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 29, 2018
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS. PR-URL: #20926 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 4 has been unsupported since 2018-05-01, but the changelog was out
of date and said that Node 4 was still in LTS.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes