test: remove message argument from strictEqual()#20912
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). Fixes: nodejs#20911 Refs: https://www.nodetodo.org/getting-started
benjamingr approved these changes May 23, 2018
Member
benjamingr left a comment
benjamingr left a comment There was a problem hiding this comment.
Thank you for doing this and your contribution and welcome to Node.js
Changes look good to me.
Member
benjamingr commented May 23, 2018
Collaborators please +1 this comment to support fast-tracking this pull request. |
Member
benjamingr commented May 23, 2018
Trott approved these changes May 23, 2018
Trott added fast-track 
jasnell approved these changes May 23, 2018
trivikr approved these changes May 23, 2018
tniessen approved these changes May 23, 2018
Member
Trott commented May 23, 2018
Three CI failures, but probably unrelated. Let's get some re-runs to see. First up, OS X: https://ci.nodejs.org/job/node-test-commit-osx/18802/ |
ryzokuken approved these changes May 23, 2018
Contributor
ryzokuken left a comment
ryzokuken left a comment There was a problem hiding this comment.
LGTM.
Thanks for your contribution! 🎉
Member
Trott commented May 23, 2018
OS X was green. Windows and Linux CI are currently disasters so let's wait until that gets all straightened out before re-running those... |
BridgeAR approved these changes May 24, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 25, 2018
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). PR-URL: nodejs#20912Fixes: nodejs#20911 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
BridgeAR commented May 25, 2018
targos pushed a commit that referenced this pull request May 25, 2018
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). PR-URL: #20912Fixes: #20911 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
test/parallel/test-require-process.js, the last thing in the test isa call to
assert.strictEqual(). It has a string literal as its thirdargument. Unfortunately, that means that the diff between the two values
being compared will be suppressed if there is an
AssertionError. That'snot helpful for debugging.
This is fixed by removing the third argument from the call. It is,
however, preserved in a comment above the call to
assert.strictEqual().This issue was provided by @Trott of nodetodo.org. Gratitude! 🙏
Fixes: #20911
Refs: https://www.nodetodo.org/getting-started
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes