tools: fix sorting in doc/type-parser.js#20976
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This section groups type links by their home modules and sort these groups alphabetically, so `modules` types should go before the `net` types.
nodejs-github-bot added doc 
vsemozhetbyt added the fast-track 
ContributorAuthor
vsemozhetbyt commented May 26, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
ContributorAuthor
vsemozhetbyt commented May 26, 2018
benjamingr approved these changes May 26, 2018
vsemozhetbyt added the author ready 
cjihrig approved these changes May 26, 2018
lpinca approved these changes May 26, 2018
vsemozhetbyt added a commit that referenced this pull request May 26, 2018
This section groups type links by their home modules and sort these groups alphabetically, so `modules` types should go before the `net` types. PR-URL: #20976 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ContributorAuthor
vsemozhetbyt commented May 26, 2018
Landed in c241b7d |
MylesBorins pushed a commit that referenced this pull request May 29, 2018
This section groups type links by their home modules and sort these groups alphabetically, so `modules` types should go before the `net` types. PR-URL: #20976 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis section groups type links by their home modules and sort these groups alphabetically, so
modulestypes should go before thenettypes.