test: improve error message in async-wrap test#20948
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Refs: https://github.com/nodejs/node/pull/20940/files#r190707951 Error message will now look more like this: AssertionError [ERR_ASSERTION]: EXIT CODE: 3, STDERR:undefined:0RangeError: Maximum call stack size exceededCurrently, it's this: AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:+ expected - actual- 3+ 0 |
richardlau approved these changes May 24, 2018
Improve AssertionError message in test/parallel/test-async-wrap-pop-id-during-load.js to include the contents of stderr when the spawned process fails. Refs: https://github.com/nodejs/node/pull/20940/files#r190707951
MemberAuthor
Trott commented May 24, 2018
MemberAuthor
Trott commented May 24, 2018
👍 here for fast-tracking. |
Trott added the author ready 
trivikr approved these changes May 25, 2018
lpinca approved these changes May 25, 2018
BridgeAR approved these changes May 25, 2018
jasnell approved these changes May 25, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 25, 2018
Improve AssertionError message in test/parallel/test-async-wrap-pop-id-during-load.js to include the contents of stderr when the spawned process fails. Refs: https://github.com/nodejs/node/pull/20940/files#r190707951 PR-URL: nodejs#20948 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
BridgeAR commented May 25, 2018
Landed in f315081 🎉 |
MylesBorins pushed a commit that referenced this pull request May 29, 2018
Improve AssertionError message in test/parallel/test-async-wrap-pop-id-during-load.js to include the contents of stderr when the spawned process fails. Refs: https://github.com/nodejs/node/pull/20940/files#r190707951 PR-URL: #20948 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve AssertionError message in
test/parallel/test-async-wrap-pop-id-during-load.js to include the
contents of stderr when the spawned process fails.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes