doc: make minor improvements to fs.realpath() docs#20953
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead.
nodejs-github-bot added doc 
MemberAuthor
| If `path` resolves to a socket or a pipe, the function will return a system | ||
| dependent name for that object. | ||
| Synchronous version of [`fs.realpath()`][]. Returns the resolved pathname. |
Member
There was a problem hiding this comment.
This is almost but not quite reversing #17059. (Not objecting, just pointing out.)
BridgeAR approved these changes May 25, 2018
BridgeAR added the author ready MemberAuthor
Trott commented May 28, 2018
@nodejs/documentation @nodejs/fs |
jasnell approved these changes May 29, 2018
Trott added a commit to Trott/io.js that referenced this pull request May 30, 2018
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead. PR-URL: nodejs#20953 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
Trott commented May 30, 2018
Landed in 89d211f |
addaleax pushed a commit that referenced this pull request May 31, 2018
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead. PR-URL: #20953 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make canonical vs. unique text more precise and eliminate quotation
marks. Remove repeated text from fs.realpathSync(), linking to
fs.realpath() instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes