Skip to content

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorinsMylesBorins commented Jun 6, 2018

2018-06-06, Version 10.4.0 (Current), @MylesBorins

Notable Changes

  • deps:
  • update V8 to 6.7.288.43 (Michaël Zasso) #19989
  • stream:
    • ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437

Commits

gireeshpunathiland others added 30 commits May 31, 2018 11:34
In test-child-process-fork-closed-channel-segfault.js, race condition is observed between the server getting closed and the worker sending a message. Accommodate the potential errors. Earlier, the same race was observed between the client and server and was addressed through ignoring the relevant errors through error handler. The same mechanism is re-used for worker too. The only difference is that the filter is applied at the callback instead of at the worker's error listener. Refs: #3635 (comment)Fixes: #20836 PR-URL: #20973 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Add missing prefix `crypto.constants.` to `RSA_PKCS1_PADDING` in `crypto.privateEncrypt()`, `crypto.privateDecrypt()`, `crypto.publicEncrypt()`, and `crypto.publicDecrypt()`. PR-URL: #20991 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This commit removes the inclusion of req_wrap-inl.h from udp_wrap.h, and tty_wrap.cc as they are not used. PR-URL: #20996 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Raise awareness against the catastrophic memory fragmentation that can be created while using the asynchronous zlib APIs. PR-URL: #20380 Refs: #8871 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #21017 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
PR-URL: #20974 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
`flaky-test-child-process-fork-net` has been failing constantly for the past few days, and all solutions suggestes so far were didn't work. Marking it as faky while the issue is not fixed. Ref: #21012 Ref: #20973 Ref: #20973 PR-URL: #21018 Refs: #21012 Refs: #20973 Refs: #20973 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
When passing{} or{encoding: 'utf8' } as options to readFile, the flag is not defaulted to 'r' unlike normal fs. This fix makes fs.promises.readFile() act consistent with fs.readFile(). It also fixes another issue with fs.promises.readfile() where it returned a Buffer instead of an empty string when encoding is provided. PR-URL: #20268 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
To increase test coverage for fs.promises by adding a test for lchmod. PR-URL: #20584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
test-fs-readfile-tostring-fail is failing frequently on OSX machines. There's a PR to fix this issue in libuv, but while the fix don't land on Node.js this test should be marked as flaky. Ref: #16601 Ref: libuv/libuv#1742 PR-URL: #21013 Refs: #16601 Refs: libuv/libuv#1742 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #20962 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead. PR-URL: #20953 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Implement utilities for easier debugging of Node.js core code, inspired by the HTTP/2 debugging code. Debugging is, however, implemented at runtime rather than at compile time, controlled through a new `NODE_DEBUG_NATIVE=categories` environment variable. The runtime overhead in the debugging-disabled case amounts to 1 well-cachable one-byte read per debug call. PR-URL: #20987 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove `--debug-http2` as a compile-time feature and make all debug statements available using `NODE_DEBUG_NATIVE=http2` at runtime. This probably makes the debugging-enabled case a bit slower due to additional string concatenations, but switching to a runtime-checking system makes debugging more flexible and can be applied more easily to other parts of the source code as well. PR-URL: #20987 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Record the state of the stdio file descriptors on start-up and restore them to that state on exit. This should prevent issues where node.js sometimes leaves stdio in raw or non-blocking mode. Co-authored-by: Krzysztof Taborski <[email protected]> PR-URL: #20592Fixes: #14752Fixes: #21020 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes an issue where Stream.pipeline wouldn't re-throw errors on a stream if no callback was specified, thus swallowing said errors. Fixes: #20303 PR-URL: #20437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
There appear to be rendering issues with inconsistent glyph width when using the Monaco font on non-macOS machines. This change updates the native CSS font stack to use the same font stack as Boostrap does, minus the Monaco font. PR-URL: #21036 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yazhong Liu <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Use `TRACE_EVENT_METADATA1` to include just the node.js version for now. Later this can be expanded to include more version and platform details. PR-URL: #20852 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]>
just replaced `than` with `that`. - wrong: the N-API functions than can be used to change - correct: the N-API functions that can be used to change Fixes: #21049 PR-URL: #21060 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Before PR 20592, closing all handles associated with the main event loop would also mean that `uv_tty_reset_mode()` can’t function properly because the corresponding FDs have already been closed. Add regression tests for this condition. Refs: #21020 Refs: #20592 PR-URL: #21027 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail. PR-URL: #21019 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. PR-URL: #20997Fixes: #20992 Reviewed-By: James M Snell <[email protected]>
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. PR-URL: #21016Fixes: #21008 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #20959 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
On process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value. PR-URL: #20956 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #19989 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #19989 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Synchronize source files list with upstream's BUILD.gn. PR-URL: #19989 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Original commit message: [api] introduce v8::Value::IsModuleNamespaceObject This allows an embedder to check if a Value is a module namespace object. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idffceff451dd5f5c6a53d4cb3ce02c1c2c5b653c Reviewed-on: https://chromium-review.googlesource.com/1011762 Reviewed-by: Georg Neis <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{#52597} Refs: v8/v8@39d546a PR-URL: #20016 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Refs: v8/v8@9fb02b5 Original commit message: Allow function callbacks to have Proxy as receiver. [email protected] Bug: v8:5773 Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b Reviewed-on: chromium-review.googlesource.com/1046088 Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{#53015} PR-URL: #20575 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
@targos
Copy link
Member

targos commented Jun 6, 2018

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

stream: ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437

Maybe this should be in notable changes?

addaleaxand others added 3 commits June 6, 2018 14:28
Otherwise, this turns into an infinite loop when the flag is set, because it makes `MakeCallback()` return immediately. Backport-PR-URL: #21168 PR-URL: #20884 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Currently `make doc-only` is updating the package-lock.json which is breaking our release build. This adds the flags `--no-package-lock` when running `npm install` to ensure the package-lock.json is not changed unintentionally by running make PR-URL: #21015 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Notable Changes: * **deps**: - update V8 to 6.7.288.43 (Michaël Zasso) #19989 * **stream**: - ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437 PR-URL: #21167
@MylesBorins
Copy link
ContributorAuthor

@mcollina
Copy link
Member

@targos yes, updated the PR.

@MylesBorins
Copy link
ContributorAuthor

MylesBorins commented Jun 6, 2018

@nodejs/platform-aix looks like we are consistently getting the AIX failure

sequential/test-fs-readfile-tostring-fail

https://ci.nodejs.org/job/node-test-commit-aix/15560/testReport/

timing out

edit:
one more run of aix CI... this test seems to be flip flopping as passing / failing https://ci.nodejs.org/job/node-test-commit-aix/15562/

@gabrielschulhof
Copy link
Contributor

@MylesBorins is it too late to squeeze #21129 (a regression fix) into this release?

@MylesBorins
Copy link
ContributorAuthor

@gabrielf if we were to do that we are going to likely have to push the release by 24 hours, which I would prefer not to do. I'm about to wrap up for the day and don't have time to re run CI + CITGM.

If the AIX CI fails again I may just push the release anyways, will keep you up to date

@MylesBorins
Copy link
ContributorAuthor

rerun of AIX looks good moving forward with promotion

@MylesBorinsMylesBorins merged commit 1e88953 into v10.xJun 6, 2018
MylesBorins added a commit that referenced this pull request Jun 6, 2018
MylesBorins added a commit that referenced this pull request Jun 6, 2018
Notable Changes: * **deps**: - update V8 to 6.7.288.43 (Michaël Zasso) #19989 * **stream**: - ensure Stream.pipeline re-throws errors without callback (Blaine Bublitz) #20437 PR-URL: #21167
@addaleax
Copy link
Member

Fwiw, it was my understanding that V8 major bumps in existing release lines would come with at least one RC or so? I’m not having any specific concern here, but I’d appreciate it if we could clarify whether there is any rule around that?

@addaleaxaddaleax deleted the v10.4.0-proposal branch June 6, 2018 14:34
@MylesBorins
Copy link
ContributorAuthor

MylesBorins commented Jun 6, 2018 via email

Matoran added a commit to Matoran/ccxt that referenced this pull request Jul 1, 2021
ccxt is now using BigInt ccxt#9439 which have been included to nodejs 10.4.0 nodejs/node#21167 check 4c48b69e90 nodejs/node@4c48b69e90
@MatoranMatoran mentioned this pull request Jul 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.metaIssues and PRs related to the general management of the project.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@MylesBorins@targos@mcollina@gabrielschulhof@addaleax@nodejs-github-bot@gireeshpunathil@DiegoRBaquero@danbev@lpinca@bnoordhuis@bdistin@devsnek@Trott@phated@silverwind@jasnell@ohbarye@apapirovski@starkwang