tools: update ESLint to 5.3.0#22134
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Since the lite CI runs the linter and none of the other jobs in node-test-pull-request touch this code, the lite CI is probably sufficient here. |
MemberAuthor
Trott commented Aug 5, 2018
Test failure is a known flaky (#21038). |
bengl approved these changes Aug 5, 2018
MemberAuthor
Trott commented Aug 5, 2018
@nodejs/linting |
silverwind approved these changes Aug 5, 2018
MemberAuthor
Trott commented Aug 8, 2018
Landed in 6ad12d4 |
Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
PR-URL: nodejs#22134 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22134 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
2 tasks
This was referenced Aug 16, 2018
This was referenced May 16, 2022
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22134 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we made some efforts to make the ESLint updates in Node.js core a little bit less churn-y, maybe we can do more frequent smaller updates like this? (Or maybe it's still too churn-y?)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes