tools: add no-misleading-character-class ESLint rule#22278
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
vsemozhetbyt commented Aug 12, 2018
cc @nodejs/linting |
ContributorAuthor
vsemozhetbyt commented Aug 12, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
BridgeAR approved these changes Aug 12, 2018
trivikr approved these changes Aug 12, 2018
jasnell approved these changes Aug 12, 2018
cjihrig approved these changes Aug 12, 2018
vsemozhetbyt added the fast-track ContributorAuthor
vsemozhetbyt commented Aug 12, 2018
Landed in 801c490 |
vsemozhetbyt added a commit that referenced this pull request Aug 12, 2018
Refs: https://eslint.org/docs/rules/no-misleading-character-class PR-URL: #22278 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 13, 2018
Refs: https://eslint.org/docs/rules/no-misleading-character-class PR-URL: #22278 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Aug 16, 2018
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
Refs: https://eslint.org/docs/rules/no-misleading-character-class PR-URL: nodejs/node#22278 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesESLint 5.3.0 adds a simple new rule that seems helpful for increasing Unicode support in JavaScript and Node.js:
no-misleading-character-class.Since we have already updated to the last version, we can toggle this rule on.
No relevant issues detected in our code or docs.