Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
doc: replace _WG_ with _team_#22183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Aug 7, 2018
Trott commented Aug 8, 2018 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Re-running lite job now that #22184 has landed. |
Trott commented Aug 8, 2018
vsemozhetbyt commented Aug 8, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Trott commented Aug 8, 2018
AFAICT, there is no N-API Working Group. There *is* an N-API team, but AFAIK there is no charter etc. (And if I'm wrong and there is, then https://nodejs.org/en/about/working-groups/ needs an update!)
Trott commented Aug 8, 2018
Hmmm...it appears that the lite-pipeline job may not rebase against master. So it's not picking up the recently-landed fix. Guess I'll rebase and force push and see if that helps things along... |
Trott commented Aug 8, 2018
Trott commented Aug 8, 2018
@nodejs/tsc @nodejs/n-api |
mcollina left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MylesBorins left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AFAICT, there is no N-API Working Group. There *is* an N-API team, but AFAIK there is no charter etc. (And if I'm wrong and there is, then https://nodejs.org/en/about/working-groups/ needs an update!) PR-URL: nodejs#22183 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott commented Aug 8, 2018
Landed in fcb46a4 |
AFAICT, there is no N-API Working Group. There *is* an N-API team, but AFAIK there is no charter etc. (And if I'm wrong and there is, then https://nodejs.org/en/about/working-groups/ needs an update!) PR-URL: #22183 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
AFAICT, there is no N-API Working Group. There *is* an N-API team, but AFAIK there is no charter etc. (And if I'm wrong and there is, then https://nodejs.org/en/about/working-groups/ needs an update!) PR-URL: nodejs/node#22183 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
AFAICT, there is no N-API Working Group. There is an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)
Checklist