test: update certificates and private keys#22184
Uh oh!
There was an error while loading. Please reload this page.
Conversation
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 9999 days for all of them to prevent this from happening again in near future. Fix: #22182
indutny commented Aug 7, 2018
cc @MylesBorins @nodejs/crypto @bnoordhuis |
test/fixtures/keys/Makefile Outdated
| ca3-csr.pem: ca3.cnf ca3-key.pem | ||
| openssl req -new \ | ||
| -extensions v3_ca \ | ||
| -days 9999 \ |
There was a problem hiding this comment.
Gosh, this slipped my quick review. It isn't really necessary, since the days are set in ca3.cnf.
There was a problem hiding this comment.
Should we remove it or just leave it?
MylesBorins commented Aug 7, 2018
MylesBorins commented Aug 7, 2018
@indutny no bueno test.parallel/test-crypto-sign-verify all failing https://ci.nodejs.org/job/node-test-commit-linux/20522/nodes=alpine-latest-x64/ |
indutny commented Aug 8, 2018
Should be fixed now. |
MylesBorins commented Aug 8, 2018
MylesBorins left a comment
MylesBorins left a comment There was a problem hiding this comment.
LGTM
we should fast track this as it is breaking lots of things
jasnell commented Aug 8, 2018
I wonder if we shouldn't look at potentially dynamically generating these every so often |
one last ci with sn extra 9... giving us 273 years to figure this out instead of 27 |
jasnell commented Aug 8, 2018
Ah yes, good ole Node.js 557.0.0 |
MylesBorins commented Aug 8, 2018
@indutny still getting failures on arm https://ci.nodejs.org/job/node-test-binary-arm/2608/RUN_SUBSET=5,label=pi3-docker/console |
indutny commented Aug 8, 2018
|
MylesBorins commented Aug 8, 2018
@mhdawson and I dug in a bunch and it seems like the failures on arm are infra related... potentially during setup @rvagg can you dig into this? One more ci: https://ci.nodejs.org/job/node-test-pull-request/16265/ landing if green |
Trott left a comment
Trott left a comment There was a problem hiding this comment.
Rubber-stamp LGTM if CI is green. +1 to fast-tracking
Trott commented Aug 8, 2018
parallel/test-tls-server-verify still failing on Raspberry Pi... |
MylesBorins commented Aug 8, 2018
oops... I did the status file wrong re-running arm https://ci.nodejs.org/job/node-test-commit-arm-fanned/2721/ |
rvagg commented Aug 8, 2018
Diagnosis & fix nodejs/build#1432 |
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Trott commented Aug 8, 2018
Custom suites failed to |
Trott commented Aug 8, 2018
Unrelated flaky on LinuxONE, re-running: https://ci.nodejs.org/job/node-test-commit-linuxone/3652/ |
Trott commented Aug 8, 2018
Custom suites passed. |
Trott commented Aug 8, 2018
LinuxONE passed. |
Trott commented Aug 8, 2018
Argh, the |
Trott commented Aug 8, 2018
|
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: nodejs/node#22184Fixes: nodejs/node#22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 9999 days for all of them to prevent this from
happening again in near future.
Fix: #22182
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes