Skip to content

deps: icu: apply workaround patch to 62.1 for significant digits#23764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srl295 merged 0 commits into from
Oct 23, 2018
Merged

deps: icu: apply workaround patch to 62.1 for significant digits #23764

srl295 merged 0 commits into from
Oct 23, 2018
+0 −0

Conversation

@srl295
Copy link
Member

@srl295srl295 commented Oct 19, 2018•
edited
Loading

patch from https://chromium.googlesource.com/chromium/deps/icu/+/master/patches/nf_maxsig.patch

from https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU bug: https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2018

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1302/pipeline

@srl295srl295 self-assigned this Oct 19, 2018
@nodejs-github-botnodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Oct 19, 2018
@srl295srl295 changed the title deps: icu: apply workaround patchdeps: icu: apply workaround patch to 62.1 for significant digitsOct 19, 2018
@srl295
Copy link
MemberAuthor

srl295 commented Oct 19, 2018•
edited
Loading

for ICU 62 this warning will appear:

WARNING: Using floating patch "tools/icu/patches/62/source/i18n/decimfmt.cpp" from "tools/icu"
WARNING: warnings were emitted in the configure phase

This will go away with ICU 63, #23715 because ICU 63 has fixed this issue.

@srl295srl295 requested a review from devsnekOctober 19, 2018 20:57
@srl295srl295 mentioned this pull request Oct 19, 2018
Merged
@srl295srl295 requested a review from TimothyGuOctober 19, 2018 20:59
@srl295srl295force-pushed the patch-icu-62-sigdig branch from 4b61932 to 6576f41CompareOctober 19, 2018 22:58
@srl295
Copy link
MemberAuthor

srl295 commented Oct 19, 2018

@jasnell thanks. Rebased and fixed a linter problem (long line)

@srl295srl295force-pushed the patch-icu-62-sigdig branch from 6576f41 to 4a21d69CompareOctober 22, 2018 22:19
@srl295srl295 requested a review from refackOctober 23, 2018 01:27
@srl295
Copy link
MemberAuthor

srl295 commented Oct 23, 2018

CI : https://ci.nodejs.org/job/node-test-pull-request/18059/

@srl295srl295 closed this Oct 23, 2018
@srl295srl295force-pushed the patch-icu-62-sigdig branch from 4a21d69 to 4194b05CompareOctober 23, 2018 20:33
@srl295srl295 merged commit 4194b05 into nodejs:masterOct 23, 2018
@srl295srl295 deleted the patch-icu-62-sigdig branch October 23, 2018 20:33
targos pushed a commit that referenced this pull request Oct 24, 2018
@srl295@targos
deps: icu: apply workaround patch
ab58439
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
@srl295srl295 mentioned this pull request Oct 24, 2018
Merged
@targostargos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 26, 2018

@srl295 I've landed this on 8.x and 10.x staging. Please lmk if it shouldn't have landed

MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@srl295@MylesBorins
deps: icu: apply workaround patch
b988792
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@srl295@MylesBorins
deps: icu: apply workaround patch
b2fbefb
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295@rvagg
deps: icu: apply workaround patch
34d9129
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295@rvagg
deps: icu: apply workaround patch
2a10f59
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@srl295@MylesBorins
deps: icu: apply workaround patch
1bed110
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@devsnekdevsnekAwaiting requested review from devsnek

@TimothyGuTimothyGuAwaiting requested review from TimothyGu

+1 more reviewer

@refackrefackrefack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srl295srl295

Labels

i18n-apiIssues and PRs related to the i18n implementation.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srl295@nodejs-github-bot@MylesBorins@refack@jasnell