2018-10-30 Version 10.13.0 'Dubnium' (LTS)

[MylesBorins]

2018-10-30, Version 10.13.0 'Dubnium' (LTS), @MylesBorins

This release marks the transition of Node.js 10.x into Long Term
Support (LTS) with the codename 'Dubnium'. The 10.x release line
now moves in to "Active LTS" and will remain so until April 2020.
After that time it will move in to "Maintenance" until end of
life in April 2021.

Notable Changes

This release only includes minimal changes necessary to fix known regressions prior to LTS.

Commits

• [2ba6010082] - buffer: fix crash for invalid index types (Anna Henningsen)
• [2cd68be69d] - build: spawn make test-ci with -j1 (Refael Ackermann) #23733
• [1003f4c975] - deps: fix wrong default for v8 handle zapping (Refael Ackermann) #23801

[nodejs-github-bot]

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1340/pipeline

[MylesBorins]

@nodejs/release please lmk if you think we should include any changes in this release... we currently have a fairly decent backlog on staging, which I think includes semver-minor changes. While we could include them in this release it would arguably be against our LTS policy (as changes will not have been in a release for 2 weeks). We do not, afaik, have explicit policy around the initial LTS release... but have discussed in the past releasing only the bit flip to LTS rather than accompanying it with other changes

[targos]

I'm +1 on a release with minimal changes.

We should include #23801 when it lands

[targos]

A test is failing: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6488/testReport/junit/(root)/test/parallel_test_process_release/

[mhdawson]

Test is failing because it needs to be aware of the new release

// it's expected that future LTS release lines will have additional// branches in hereif(versionParts[0]==='4'&&versionParts[1]>=2){assert.strictEqual(process.release.lts,'Argon');}elseif(versionParts[0]==='6'&&versionParts[1]>=9){assert.strictEqual(process.release.lts,'Boron');}elseif(versionParts[0]==='8'&&versionParts[1]>=9){assert.strictEqual(process.release.lts,'Carbon');}else{assert.strictEqual(process.release.lts,undefined);}

Missing the else if for 10

[mhdawson]

LGTM once test is updated.

[cxreg]

This codename is uppercased in Boron and Carbon. Is there a reason for a change to this naming pattern?

[MylesBorins]

fixed

[cxreg]

@MylesBorins did you intend to rebase to v10.x-staging with that last commit?

[MylesBorins]

@cxreg I didn't, thanks for the due diligence

[targos]

Another change that should be included IMO: #23795

[srl295]

edit no notable changes… OK, this can be next time.

maybe some ICU <3 ? in decreasing order of importance

• ICU 63.1 deps: ICU4C 63.1 #23244
• download retry doc: document and warn if the ICU version is too old #23766

Easily skip this one if ICU 63.1 lands:

• significant digit workaround for ICU 62.1 - deps: icu: apply workaround patch to 62.1 for significant digits #23764 - this would ONLY help someone who explicitly compiles 10.x against icu 62.1. Already fixed in 63.1. Does include a regression test though.

[bnb]

Thank you for your work on this @MylesBorins ❤️

I also very much appreciate the precedent of "no changes" outside of a SemVer minor patch. Feels much tidier and provides a simple way to explain the change to people.

[MylesBorins]

@targos I've landed #23801 and am waiting to see what happens in #23795

@srl295 I'm going to push back on landing any of the changes you've outlined here. As we are keeping this release targeting to minimal changes. I'd like to see the changes above live in an 11.x release before landing them in LTS

[MylesBorins]

CI: https://ci.nodejs.org/job/node-test-pull-request/18152/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1600/

rc.1: https://nodejs.org/download/rc/v10.13.0-rc.1/:

[cujarrett]

🎉 Thanks Node contributors and maintainers! 🎉

[MylesBorins]

updated with two more commits to fix known regressions. Kicking off one last round of CI

CI: https://ci.nodejs.org/job/node-test-pull-request/18216/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1605/
rc.2: https://nodejs.org/download/rc/v10.13.0-rc.2/

[MylesBorins]

Rebuilding OSX: https://ci.nodejs.org/job/node-test-commit-osx/22254/

[targos]

🎉 🎉 🎉

[joshgav]

Thanks @MylesBorins! I think you still need to add a latest-dubnium folder to https://nodejs.org/dist/.

[richardlau]

Thanks @MylesBorins! I think you still need to add a latest-dubnium folder to https://nodejs.org/dist/.

Opened nodejs/nodejs-latest-linker#2 against the linker tool.

[MylesBorins]

I manually created https://nodejs.org/download/release/latest-dubnium/ but we still need to update the automation script

[rvagg]

latest-linker updated and deployed, thanks @richardlau for the code and @joshgav for the ping