src: fix compiler warnings#23880
Closed
src: fix compiler warnings #23880
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Otherwise, the compiler complains about a missing definition for the (inline) `Calloc` function.
This fixes a compiler warning about comparing against the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.
These have been overlooked in 036fbdb.
nodejs-github-bot added c++ 
richardlau approved these changes Oct 25, 2018
cjihrig approved these changes Oct 25, 2018
sam-github approved these changes Oct 25, 2018
lpinca approved these changes Oct 25, 2018
eugeneo approved these changes Oct 25, 2018
jasnell approved these changes Oct 25, 2018
targos approved these changes Oct 26, 2018
Contributor
mmarchini commented Oct 26, 2018
mmarchini added the author ready 
mmarchini approved these changes Oct 26, 2018
MemberAuthor
addaleax commented Oct 28, 2018
Landed in 336651b...1b47354 |
pullbot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
Otherwise, the compiler complains about a missing definition for the (inline) `Calloc` function. PR-URL: nodejs#23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
pullbot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
This fixes a compiler warning about comparing against the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant. PR-URL: nodejs#23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
pullbot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
These have been overlooked in 036fbdb. PR-URL: nodejs#23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
Otherwise, the compiler complains about a missing definition for the (inline) `Calloc` function. PR-URL: #23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
This fixes a compiler warning about comparing against the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant. PR-URL: #23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
These have been overlooked in 036fbdb. PR-URL: #23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
3 tasks
refack added a commit to refack/node that referenced this pull request Oct 31, 2018
PR-URL: nodejs#23961 Refs: nodejs#23954 Refs: nodejs#23910 Refs: nodejs#23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Contributor
MylesBorins commented Nov 27, 2018
@targos it looks like you meant to remove the dont-land-label. LMK if this was a mistake |
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Otherwise, the compiler complains about a missing definition for the (inline) `Calloc` function. PR-URL: #23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
These have been overlooked in 036fbdb. PR-URL: #23880 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Member
targos commented Nov 28, 2018
Contributor
MylesBorins commented Nov 28, 2018
@targos in that case would it be better to add the backported-to label instead, since some of the commits landed? |
Member
targos commented Nov 28, 2018
SGTM |
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This was referenced Dec 7, 2018
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address a number of compiler warnings I am currently seeing on
master.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes