Skip to content

src: fix compiler warning#23954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjihrig wants to merge 1 commit into from
Closed

src: fix compiler warning #23954

cjihrig wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Oct 29, 2018

The warning is:

../src/util.h:65:11: warning: inline function 'node::Calloc<unsigned char>' is not defined [-Wundefined-inline] inline T* Calloc(size_t n); ^ ../src/aliased_buffer.h:41:15: note: used here buffer_ = Calloc<NativeT>(count);
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
src: fix compiler warning
ce42950
The warning is: ../src/util.h:65:11: warning: inline function 'node::Calloc<unsigned char>' is not defined [-Wundefined-inline] inline T* Calloc(size_t n); ^ ../src/aliased_buffer.h:41:15: note: used here buffer_ = Calloc<NativeT>(count);
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2018

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1409/pipeline

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 29, 2018
bnoordhuis
bnoordhuis approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@bnoordhuisbnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #23910?


I'll get my coat.

@cjihrig
Copy link
ContributorAuthor

cjihrig commented Oct 29, 2018

@bnoordhuis oops. Would you rather land 4e10934?

@bnoordhuis
Copy link
Member

bnoordhuis commented Oct 29, 2018

Don't worry, it's fine. :-)

@refackrefack mentioned this pull request Oct 29, 2018
Merged
3 tasks
@cjihrig
Copy link
ContributorAuthor

cjihrig commented Oct 29, 2018•
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/18214/

EDIT: Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18217/

@mmarchinimmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 29, 2018
@joyeecheung
Copy link
Member

joyeecheung commented Oct 30, 2018

Landed in 93335cb

joyeecheung pushed a commit that referenced this pull request Oct 30, 2018
@cjihrig@joyeecheung
src: fix compiler warning
93335cb
The warning is: ../src/util.h:65:11: warning: inline function 'node::Calloc<unsigned char>' is not defined [-Wundefined-inline] inline T* Calloc(size_t n); ^ ../src/aliased_buffer.h:41:15: note: used here buffer_ = Calloc<NativeT>(count); PR-URL: #23954 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
@richardlau
Copy link
Member

richardlau commented Oct 30, 2018

Landed in 93335cb

@joyeecheung Did ncu let this through? It's been open < 48 hours and wasn't fast tracked either.

(Just to be clear, I have no issue with the change itself, just the process.)

@joyeecheung
Copy link
Member

joyeecheung commented Oct 30, 2018

@richardlau oops, my bad, I ignored the warning because I assumed this was fast-tracked

@cjihrigcjihrig deleted the warning branch October 30, 2018 12:53
refack added a commit to refack/node that referenced this pull request Oct 31, 2018
@refack
build: add -Werror=undefined-inline to clang builds
c515e5c
PR-URL: nodejs#23961 Refs: nodejs#23954 Refs: nodejs#23910 Refs: nodejs#23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@targos
Copy link
Member

targos commented Nov 2, 2018

Depends on #23808 to land on v11.x-staging

targos pushed a commit that referenced this pull request Nov 2, 2018
@refack@targos
build: add -Werror=undefined-inline to clang builds
4651cd7
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@cjihrig@targos
src: fix compiler warning
11e9d66
The warning is: ../src/util.h:65:11: warning: inline function 'node::Calloc<unsigned char>' is not defined [-Wundefined-inline] inline T* Calloc(size_t n); ^ ../src/aliased_buffer.h:41:15: note: used here buffer_ = Calloc<NativeT>(count); PR-URL: #23954 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@refack@MylesBorins
build: add -Werror=undefined-inline to clang builds
bd73da0
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack@rvagg
build: add -Werror=undefined-inline to clang builds
cb44bd0
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@cjihrig@rvagg
src: fix compiler warning
53fac5c
The warning is: ../src/util.h:65:11: warning: inline function 'node::Calloc<unsigned char>' is not defined [-Wundefined-inline] inline T* Calloc(size_t n); ^ ../src/aliased_buffer.h:41:15: note: used here buffer_ = Calloc<NativeT>(count); PR-URL: #23954 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack@MylesBorins
build: add -Werror=undefined-inline to clang builds
a1b5643
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@refack@MylesBorins
build: add -Werror=undefined-inline to clang builds
2e83f1e
PR-URL: #23961 Refs: #23954 Refs: #23910 Refs: #23880 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
@codebytere
Copy link
Member

codebytere commented Jan 13, 2019

Adding the above label as patch application reports:
No changes -- Patch already applied.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

+3 more reviewers

@danbevdanbevdanbev approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

@mmarchinimmarchinimmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@cjihrig@nodejs-github-bot@bnoordhuis@joyeecheung@richardlau@targos@codebytere@danbev@jasnell@addaleax@TimothyGu@mmarchini