Skip to content

Proof reading#23977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jagannathBhat wants to merge 2 commits into from
Closed

Proof reading #23977

jagannathBhat wants to merge 2 commits into from

Conversation

@jagannathBhat
Copy link
Contributor

@jagannathBhatjagannathBhat commented Oct 30, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 30, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 30, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Oct 30, 2018
addaleax
addaleax approved these changes Oct 30, 2018
View reviewed changes
@refack
Copy link
Contributor

refack commented Oct 30, 2018

fast-tracking?

IMHO it should be fixed first.

@vsemozhetbyt

This comment has been minimized.

Sign in to view
@seishunseishun mentioned this pull request Oct 30, 2018
Closed
4 tasks
@Trott
Copy link
Member

Trott commented Oct 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1436/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2018
@Trott
Copy link
Member

Trott commented Nov 2, 2018

Landed in 67d74e4

@TrottTrott closed this Nov 2, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 2, 2018
@jagannathBhat@Trott
doc: improve COLLABORATOR_GUIDE
67d74e4
PR-URL: nodejs#23977 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 2, 2018
@jagannathBhat@targos
doc: improve COLLABORATOR_GUIDE
b8a71be
PR-URL: #23977 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@jagannathBhat@MylesBorins
doc: improve COLLABORATOR_GUIDE
17c2ddd
PR-URL: #23977 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jagannathBhat@rvagg
doc: improve COLLABORATOR_GUIDE
823b8b9
PR-URL: #23977 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jagannathBhat@MylesBorins
doc: improve COLLABORATOR_GUIDE
00c0539
PR-URL: #23977 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@jagannathBhat@MylesBorins
doc: improve COLLABORATOR_GUIDE
52215a4
PR-URL: #23977 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

@trivikrtrivikrtrivikr approved these changes

+4 more reviewers

@mscdexmscdexmscdex left review comments

@refackrefackrefack left review comments

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

@lundibundilundibundilundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@jagannathBhat@vsemozhetbyt@refack@Trott@mscdex@jasnell@addaleax@cjihrig@lundibundi@trivikr@MylesBorins@nodejs-github-bot