Skip to content

Bits of proof reading work#23978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jagannathBhat wants to merge 1 commit into from
Closed

Bits of proof reading work #23978

jagannathBhat wants to merge 1 commit into from

Conversation

@jagannathBhat
Copy link
Contributor

@jagannathBhatjagannathBhat commented Oct 30, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 30, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 30, 2018

Friendly reminder to adhere to commit message rules)

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 30, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1426/

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 30, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@seishun
Copy link
Contributor

seishun commented Oct 30, 2018

@jagannathBhat Could you please combine your three PRs into one (see #23976, #23977)? They all fix the same things, just in different files.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 2, 2018

Landed in c774dc3
Thank you.

vsemozhetbyt pushed a commit that referenced this pull request Nov 2, 2018
@jagannathBhat@vsemozhetbyt
doc: address bits of proof reading work
c774dc3
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Nov 2, 2018
@jagannathBhat@targos
doc: address bits of proof reading work
7012f72
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@jagannathBhat
Copy link
ContributorAuthor

jagannathBhat commented Nov 4, 2018

Thanks, guys.

I'm new to open-source contribution. I'll adhere to commit message rules and combine similar contributions the next time.

@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@jagannathBhat@MylesBorins
doc: address bits of proof reading work
3667a6b
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@jagannathBhat@MylesBorins
doc: address bits of proof reading work
435e7b4
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@jagannathBhat@MylesBorins
doc: address bits of proof reading work
45bfd72
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jagannathBhat@rvagg
doc: address bits of proof reading work
78d9a5e
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jagannathBhat@rvagg
doc: address bits of proof reading work
d2fc8c6
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jagannathBhat@MylesBorins
doc: address bits of proof reading work
0c923cf
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@jagannathBhat@MylesBorins
doc: address bits of proof reading work
13ca306
PR-URL: #23978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

+1 more reviewer

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jagannathBhat@vsemozhetbyt@seishun@jasnell@Trott@addaleax@MylesBorins@nodejs-github-bot