http: fix error check in Execute()#25863
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
ContributorAuthor
mscdex commented Feb 1, 2019
/cc @indutny |
Member
indutny commented Feb 1, 2019
Member
indutny commented Feb 1, 2019
Wait, I just realized that this is for 10.x branch. nvm. |
ContributorAuthor
mscdex commented Feb 5, 2019
/cc @nodejs/collaborators |
mcollina approved these changes Feb 5, 2019
Member
mcollina left a comment
mcollina left a comment There was a problem hiding this comment.
LGTM. Does this apply only on Node 10?
ContributorAuthor
mscdex commented Feb 5, 2019
@mcollina It has to be done for v6.x and v8.x as well if that's what you mean, I can do that yet. master already has the fix though. |
ContributorAuthor
mscdex commented Feb 5, 2019
BethGriggs pushed a commit that referenced this pull request Feb 5, 2019
Refs: #24738Fixes: #25858 PR-URL: #25863 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
BethGriggs commented Feb 5, 2019
Landed on |
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Refs: #24738Fixes: #25858 PR-URL: #25863 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #24738
Fixes: #25858
CI: https://ci.nodejs.org/job/node-test-pull-request/20501/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes