Skip to content

[v6.x] http: fix error check in Execute()#25939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mscdex wants to merge 1 commit into from
Closed

[v6.x] http: fix error check in Execute()#25939

mscdex wants to merge 1 commit into from

Conversation

@mscdex
Copy link
Contributor

@mscdexmscdex commented Feb 5, 2019•
edited
Loading

Refs: #24738
Fixes: #25858

CI: https://ci.nodejs.org/job/node-test-pull-request/20578/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Feb 5, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2019

@mscdex build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2512/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. v6.x labels Feb 5, 2019
@mscdexmscdex mentioned this pull request Feb 5, 2019
Closed
3 tasks
@richardlaurichardlau mentioned this pull request Feb 6, 2019
Closed
@addaleaxaddaleax changed the title http: fix error check in Execute()[v6.x] http: fix error check in Execute()Feb 9, 2019
@mscdexmscdexforce-pushed the v6-http-fix-parser-execute-error-check branch from 084ccb3 to 41f8dd5CompareFebruary 28, 2019 16:57
@mscdex
Copy link
ContributorAuthor

mscdex commented Mar 6, 2019

ping @nodejs/http

@lpinca
Copy link
Member

lpinca commented Mar 9, 2019

@mscdex I think this needs a rebase.

@mscdexmscdexforce-pushed the v6-http-fix-parser-execute-error-check branch from 41f8dd5 to 858004aCompareMarch 9, 2019 14:52
@mscdex
Copy link
ContributorAuthor

mscdex commented Mar 9, 2019

@lpinca Done.

@lpinca
Copy link
Member

lpinca commented Mar 11, 2019

@nodejs/lts @MylesBorins

@BethGriggs
Copy link
Member

BethGriggs commented Mar 11, 2019•
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21421/ [Passed]

BethGriggs pushed a commit that referenced this pull request Mar 11, 2019
@mscdex@BethGriggs
http: fix error check in Execute()
8080a9b
Refs: #24738Fixes: #25858 PR-URL: #25939 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
@BethGriggs
Copy link
Member

BethGriggs commented Mar 11, 2019

Landed in 8080a9b

@mscdexmscdex deleted the v6-http-fix-parser-execute-error-check branch March 11, 2019 16:38
@BethGriggsBethGriggs mentioned this pull request Mar 15, 2019
Merged
BethGriggs added a commit that referenced this pull request Mar 15, 2019
@BethGriggs
2019-04-02, Version 6.17.1 'Boron' (LTS)
8051716
Notable changes: * **http**: - fix error check in `Execute()` (Brian White) [#25939](#25939)
BethGriggs added a commit that referenced this pull request Mar 19, 2019
@BethGriggs
2019-04-02, Version 6.17.1 'Boron' (LTS)
f34c917
Notable changes: * **http**: - fix error check in `Execute()` (Brian White) [#25939](#25939)
BethGriggs added a commit that referenced this pull request Apr 2, 2019
@BethGriggs
2019-04-02, Version 6.17.1 'Boron' (LTS)
4fd8cd3
Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939)
BethGriggs added a commit that referenced this pull request Apr 3, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
94b3b03
Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684
BethGriggs added a commit that referenced this pull request Apr 3, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
576c2bf
Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684
BethGriggs added a commit that referenced this pull request Apr 3, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
883a0d5
Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684
@beevelopbeevelop mentioned this pull request Apr 3, 2019
Closed
BethGriggs added a commit that referenced this pull request Apr 4, 2019
@BethGriggs
2019-04-03, Version 6.17.1 'Boron' (LTS)
4005f22
Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mscdex@nodejs-github-bot@lpinca@BethGriggs@jasnell