test: skip test-cpu-prof in debug builds with code cache#27308
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The CPU profiler crashes in debug builds when code cache is enabled. Skip the test temporarily until it's fixed.
Collaborator
nodejs-github-bot commented Apr 19, 2019
MemberAuthor
joyeecheung commented Apr 19, 2019
Collaborator
nodejs-github-bot commented Apr 19, 2019
addaleax approved these changes Apr 19, 2019
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
I’m 👍 to fast-tracking if you want
MemberAuthor
Fixed the linter and the skip message. @addaleax Let's see if this is green in CI first..(it passes for me locally, previously it always crashed) |
Collaborator
nodejs-github-bot commented Apr 19, 2019
MemberAuthor
CI is green. Please thumb this up if you are +1 to fast tracking (this unbreaks debug builds on master) @nodejs/testing |
ZYSzys approved these changes Apr 19, 2019
devsnek approved these changes Apr 19, 2019
MemberAuthor
joyeecheung commented Apr 19, 2019
Landed in b66f01d |
joyeecheung added a commit that referenced this pull request Apr 19, 2019
The CPU profiler crashes in debug builds when code cache is enabled. Skip the test temporarily until it's fixed. PR-URL: #27308 Refs: #27307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
refack reviewed Apr 19, 2019
| constcommon=require('../common'); | ||
| if(process.features.debug&& | ||
| process.config.variables.node_code_cache_path==='yes'){ |
Contributor
There was a problem hiding this comment.
ATM this is not the best predicate for embedded code-cache...
I've submitted #27311 to fix the value, and this predicate (it could be any non '' value if combined with the previous manual embedding technique)
4 tasks
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.
Refs: #27307
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes