Skip to content

build: improve embedded code-cache detection#27311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
Apr 22, 2019
Merged

build: improve embedded code-cache detection #27311

refack merged 1 commit into from
Apr 22, 2019

Conversation

@refack
Copy link
Contributor

@refackrefack commented Apr 19, 2019•
edited
Loading

Follow up to #27308

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 19, 2019
@refackrefack requested a review from joyeecheungApril 19, 2019 13:44
@refackrefack mentioned this pull request Apr 19, 2019
Closed
2 tasks
joyeecheung
joyeecheung reviewed Apr 19, 2019
View reviewed changes
@refackrefackforce-pushed the fix-config-code-cache-bug branch from 0606363 to 98deba3CompareApril 19, 2019 21:59
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22570/

@refack
Copy link
ContributorAuthor

refack commented Apr 19, 2019

Added process.features.code_cache field based on compile time constant, and not build configuration.

@refackrefack added the process Issues and PRs related to the process subsystem. label Apr 19, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
joyeecheung
joyeecheung reviewed Apr 20, 2019
View reviewed changes
@refackrefack self-assigned this Apr 20, 2019
@refack
Copy link
ContributorAuthor

refack commented Apr 20, 2019

Ping @nodejs/build-files @nodejs/process

@refackrefackforce-pushed the fix-config-code-cache-bug branch from f0b5677 to cbf534cCompareApril 21, 2019 13:35
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
BridgeAR
BridgeAR reviewed Apr 21, 2019
View reviewed changes
@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
@refackrefackforce-pushed the fix-config-code-cache-bug branch from cbf534c to 4d81c09CompareApril 21, 2019 19:39
@nodejsnodejs deleted a comment from nodejs-github-botApr 21, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22602/

@refack
build: improve embedded code-cache detection
5aaf666
PR-URL: nodejs#27311 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@refackrefackforce-pushed the fix-config-code-cache-bug branch from 4d81c09 to 5aaf666CompareApril 22, 2019 18:49
@refackrefack merged commit 5aaf666 into nodejs:masterApr 22, 2019
@refackrefack deleted the fix-config-code-cache-bug branch April 22, 2019 18:51
@refackrefack removed their assignment Apr 22, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 12, 2024
Merged
Merged
nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2024
@aduh95
doc: fix history of process.features
421977c
PR-URL: #54982 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95@targos
doc: fix history of process.features
f2d74a2
PR-URL: #54982 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95@louwers
doc: fix history of process.features
cf6151c
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95@tpoisseau
doc: fix history of process.features
22a8e4a
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 10, 2025
@aduh95@marco-ippolito
doc: fix history of process.features
2e6d76b
PR-URL: #54982 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 10, 2025
@aduh95@marco-ippolito
doc: fix history of process.features
910c30f
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 10, 2025
@aduh95@marco-ippolito
doc: fix history of process.features
697a392
PR-URL: #54982 Backport-PR-URL: #56948 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> PR-URL: #54897 Refs: #54295
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes

@BridgeARBridgeARBridgeAR left review comments

@richardlaurichardlaurichardlau approved these changes

+1 more reviewer

@mihalskiymihalskiymihalskiy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@refack@nodejs-github-bot@joyeecheung@richardlau@BridgeAR@mihalskiy