Skip to content

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Feb 7, 2025

PR-URL: #54897
Refs: #54295
Reviewed-By: Ethan Arrowood [email protected]
Reviewed-By: Trivikram Kamat [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Chengzhong Wu [email protected]

cc @joyeecheung

PR-URL: nodejs#54897 Refs: nodejs#54295 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Feb 7, 2025
@joyeecheung
Copy link
Member

Thanks, do you plan to merge it soon?

@joyeecheung
Copy link
Member

Actually I think #54982 should probably also be there, though I can also just rebase on top of a bunch of REPLACEME (but they aren't really supposed to be picked up by the script in this release right?)

@marco-ippolito
Copy link
MemberAuthor

marco-ippolito commented Feb 7, 2025

Yeah that commit needs to get backported. I'll land this right after this release.

marco-ippolito added a commit that referenced this pull request Feb 10, 2025
PR-URL: #54897 Backport-PR-URL: #56948 Refs: #54295 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 10, 2025
PR-URL: #54982 Backport-PR-URL: #56948 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> PR-URL: #54897 Refs: #54295
@marco-ippolito
Copy link
MemberAuthor

Landed in de5cbdc...697a392

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.v20.xIssues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito@joyeecheung@nodejs-github-bot@aduh95