http2: do not start reading after write if new write is on wire#29399
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: nodejs#29353Fixes: nodejs#29393
addaleax added http2 
nodejs-github-bot added the c++ Closed
devnexen approved these changes Sep 2, 2019
addaleax added author ready 
Collaborator
nodejs-github-bot commented Sep 3, 2019
MemberAuthor
addaleax commented Sep 3, 2019
@nodejs/http2 Can I get another review? @nodejs/lts Would we be interested in providing LTS releases earlier than scheduled for this? This solves a bug that was introduced in the HTTP/2 security releases and may keep people from adopting them. |
cjihrig approved these changes Sep 3, 2019
jasnell approved these changes Sep 3, 2019
Collaborator
nodejs-github-bot commented Sep 4, 2019
MemberAuthor
addaleax commented Sep 4, 2019
Landed in 18cb437 |
addaleax added a commit that referenced this pull request Sep 4, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: #29353Fixes: #29393 PR-URL: #29399 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This was referenced Sep 6, 2019
Merged
addaleax added a commit to addaleax/node that referenced this pull request Sep 19, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: nodejs#29353Fixes: nodejs#29393 PR-URL: nodejs#29399 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Sep 19, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: nodejs#29353Fixes: nodejs#29393 PR-URL: nodejs#29399 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This was referenced Sep 19, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: #29353Fixes: #29393 PR-URL: #29399 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Sep 25, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: #29353Fixes: #29393 PR-URL: #29399 Backport-PR-URL: #29618 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This was referenced Sep 25, 2019
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: #29353Fixes: #29393 PR-URL: #29399 Backport-PR-URL: #29619 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don’t start reading more input data if we’re still busy writing output.
This was overlooked in 8a4a193.
Fixes: #29353
Fixes: #29393
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes