[v10.x] backport HTTP/2 security release fixups#29619
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: nodejs#29353Fixes: nodejs#29393 PR-URL: nodejs#29399 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs-github-bot added c++ Merged
Collaborator
nodejs-github-bot commented Sep 19, 2019
Collaborator
addaleax added http2 
trivikr approved these changes Sep 21, 2019
BethGriggs approved these changes Sep 27, 2019
gengjiawen approved these changes Sep 27, 2019
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
Do not crash when the session is no longer available. Fixes: #29457 PR-URL: #29459 Backport-PR-URL: #29619 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: #29353Fixes: #29393 PR-URL: #29399 Backport-PR-URL: #29619 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
BethGriggs commented Oct 1, 2019
Landed on |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports of #29399 and #29459.
These solve issues introduced in #29122. There were no conflicts, this is just to make sure it happens, ideally in the next release.