tools: update remark-preset-lint-node to 1.10.1#29982
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Oct 15, 2019
BridgeAR approved these changes Oct 15, 2019
cjihrig approved these changes Oct 15, 2019
Trott added the author ready MemberAuthor
Trott commented Oct 15, 2019
I don't want lint violations to land in the docs while this waits for the 48 hours, so I'd like to fast track. Collaborators, please 👍 here to approve. |
richardlau approved these changes Oct 15, 2019
lpinca approved these changes Oct 15, 2019
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: nodejs#29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: nodejs#29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trottforce-pushed the update-preset-to-1.10.1 branch from cfccf45 to 90b5f1bCompareMemberAuthor
Trott commented Oct 15, 2019
Landed in f4f856b...90b5f1b |
Member
targos commented Nov 8, 2019
Depends on #29864 to land on v12.x. |
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 7, 2020
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: nodejs#29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 7, 2020
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: nodejs#29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
2 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 8, 2020
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: nodejs#29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 8, 2020
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: nodejs#29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jan 8, 2020
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: #29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jan 8, 2020
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: #29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: #29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: #29982 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes better link linting, improved prohibited string linting,
and a more maintainable code base by using remark-preset-int-recommended
(thanks @nschonni!).
Update other dependencies while at it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes