stream: simplify Readable.push#31150
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the stream 
BridgeAR approved these changes Jan 1, 2020
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
BridgeAR added the author ready Collaborator
nodejs-github-bot commented Jan 2, 2020
Collaborator
Trott approved these changes Jan 3, 2020
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
LGTM, but would feel a whole lot better with some @nodejs/streams reviews. I'll also kick off a CITGM out of extra caution.
Member
Trott commented Jan 3, 2020
This comment has been minimized.
This comment has been minimized.
Member
Trott commented Jan 4, 2020
And CITGM against this PR again: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2186/ |
Member
Trott commented Jan 4, 2020
CITGM looks good. |
addaleax approved these changes Jan 9, 2020
BridgeAR pushed a commit that referenced this pull request Jan 13, 2020
PR-URL: #31150 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
BridgeAR commented Jan 13, 2020
Landed in 94549be 🎉 |
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
PR-URL: #31150 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
PR-URL: #31150 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31150 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly simplifies
Readable.push.Note, a lot easier to review if ignoring whitespace.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes