Skip to content

Conversation

@codebytere
Copy link
Member

@codebyterecodebytere commented Mar 17, 2020

2020-04-08, Version 12.16.2 'Erbium' (LTS), @codebytere

Notable Changes

  • doc:
    • add ronag to collaborators (Robert Nagy) #31498
    • add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
  • deps:
    • upgrade npm to 6.13.6 (Ruy Adorno) #31304
    • update openssl to 1.1.1e (Hassaan Pasha) #32328

Commits

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v12.x labels Mar 17, 2020
@codebytere
Copy link
MemberAuthor

Note that there are 2-3 manual backports needing rebase that i'll try to get in here as well.

@mmarchini
Copy link
Contributor

Can #32053 be included as well? It fixes a steep performance regression (and potentially straight up undefined behavior) on V8.

@codebyterecodebytereforce-pushed the v12.16.2-proposal branch 2 times, most recently from 932a3e1 to 37306beCompareMarch 17, 2020 15:56
@nodejs-github-bot
Copy link
Collaborator

@nodejsnodejs deleted a comment from nodejs-github-botMar 17, 2020
@haggholm
Copy link

Please, please, please include/backport 625d8f7007 (fixes #31752). It’s a hard crash of the whole Node process and makes dynamic worker pools unusable for us with the current LTS/12.

@ex1st
Copy link

Hello, do you planning to include #31433? Thank you.

@nodejs-github-bot
Copy link
Collaborator

@nodejsnodejs deleted a comment from nodejs-github-botMar 23, 2020
@nodejs-github-bot
Copy link
Collaborator

@MylesBorins
Copy link
Contributor

given that #32328 hasn't landed yet and we will likely want to include it in this release should we consider delaying by a week?

@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
MemberAuthor

The ASAN build seems to be failing but that was itself added in this release so i'm not sure if it's something worth blocking on.

@richardlau
Copy link
Member

The ASAN build seems to be failing but that was itself added in this release so i'm not sure if it's something worth blocking on.

@codebytere we've reverted it in master (#32324) as it seems too demanding for the current GitHub Actions runners.

@codebytere
Copy link
MemberAuthor

@richardlau ah ok i'll back it out today then!

@addaleax
Copy link
Member

@codebytere Can you remove #31201 from this PR? #32553 was just reported as a bug that was most likely introduced by it.

addaleaxand others added 3 commits March 30, 2020 10:59
Add a raw `MessagePort` benchmark that does not ping back and forth between different threads, unlike the `echo.js` benchmark, as there are some performance differences between single-threaded and multi- threaded operation, and a single-threaded Environment can be somewhat easier to work with when profiling. PR-URL: #31568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: #31541 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #31575 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@breisig
Copy link

Wasn't this supposed to be released today?

@codebytere
Copy link
MemberAuthor

@breisig that's correct, but we're experiencing failures being tracked here: nodejs/build#2271, and so will likely need to delay by a short time.

@codebytere
Copy link
MemberAuthor

codebytere commented Apr 8, 2020

@rvagg still seeing a bunch of failures in the latest above linked RC it seems - on macOS but also on CentOS

In several of them i can see:

Could not find Node.js version in this workspace

which is perhaps a symptom of the issue, but i could be reading the console output incorrectly 🤔

@rvagg
Copy link
Member

rvagg commented Apr 8, 2020

@codebytere:

21:13:44 Please update REPLACEME in Added: tags in doc/api/*.md (See doc/guides/releases.md)

It's passing on Windows because vcbuild.bat doesn't include this check. All the other platforms are checking your docs. Some doc needs to be updated. Did you use your new release tool for this? It's supposed to be doing this automatically isn't it?

@codebytere
Copy link
MemberAuthor

codebytere commented Apr 8, 2020

@rvagg a bunch of new commits were added after i used it initially (you're correct, it does do this automatically), which is likely how they snuck through. I'll update that, thanks for the catch!

Notable changes: doc: * add ronag to collaborators (Robert Nagy) [#31498](#31498) * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306) deps: * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304) * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 8, 2020

@nodejs-github-bot
Copy link
Collaborator

@codebyterecodebytere merged commit 3443e3a into v12.xApr 8, 2020
codebytere added a commit that referenced this pull request Apr 8, 2020
@targos
Copy link
Member

@codebytere are you having issues with the final steps of the release?

codebytere added a commit to nodejs/nodejs.org that referenced this pull request Apr 8, 2020
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Apr 8, 2020
@rvagg
Copy link
Member

rvagg commented Apr 9, 2020

@codebytere would you mind updating the release blog post with the macos notice please (included in the 13.x previously and the 10.x today):

macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 12.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 12.x were compiled on macOS 10.11 (El Capitan) with a minimum deployment target of macOS 10.10 (Yosemite). As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 12.x users with older versions of macOS.

@rvaggrvagg deleted the v12.16.2-proposal branch April 9, 2020 06:56
@targostargos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jun 6, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releaseIssues and PRs related to Node.js releases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@codebytere@mmarchini@nodejs-github-bot@haggholm@ex1st@MylesBorins@richardlau@addaleax@breisig@rvagg@targos@cjihrig@tniessen@rustyconover@Nef10@lundibundi@DavenportEmma@sam-github@conoro@joyeecheung