deps: remove *.pyc files from deps/npm#32387
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the npm 
Member
mcollina commented Mar 20, 2020
+1 to fast-track |
BethGriggs approved these changes Mar 20, 2020
richardlau approved these changes Mar 20, 2020
richardlau added the fast-track 
targos approved these changes Mar 20, 2020
cjihrig approved these changes Mar 20, 2020
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: nodejs#32387 Refs: nodejs#32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MemberAuthor
bnoordhuis commented Mar 20, 2020
Landed in fbecc07. |
BethGriggs pushed a commit that referenced this pull request Mar 23, 2020
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: #32387 Refs: #32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: #32387 Refs: #32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: #32387 Refs: #32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 1, 2020
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: nodejs#32387 Refs: nodejs#32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 1, 2020
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. Backport-PR-URL: #32527 PR-URL: #32387 Refs: #32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.
Refs: #32368
Refs: npm/cli#1037
I'm proposing fast-tracking this because it's annoying.