[v12.x] backport npm updates and macOS notarization#32527
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added build 
richardlau commented Mar 28, 2020
nodejs/build#2203 will need to land in conjunction with this and the 10.x backport for notarization to occur. |
rvagg commented Mar 30, 2020
|
rvagg left a comment
rvagg left a comment There was a problem hiding this comment.
I think I had a PR for this somewhere already, but it's basically this without npm so 👍.
I believe if you moved 2c02a525 (my term-size) to after the second npm update it'd probably fall out as an empty commit. But either way it should work fine. Maybe it's helpful to record that so that it would still technically compile releases without that second npm update?
MylesBorins commented Mar 30, 2020
@rvagg I landed in that order so the commits could all land cleanly, otherwise I'd have to manually redo the npm update for 6.14.4 How are you imagining we would document that? Might make sense to fix documentation and master and backport no? |
rvagg commented Mar 30, 2020
@MylesBorins I meant "record" in the sense of the commit record. So all's good, no objection to what's done here. |
richardlau commented Mar 30, 2020
That was done as part of #32495. |
PR-URL: nodejs#31977 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#32368 Refs: nodejs#32296 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: nodejs#32387 Refs: nodejs#32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#31459 Refs: nodejs#29216 Refs: sindresorhus/macos-terminal-size#3 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
PR-URL: nodejs#32495 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Includes hardened-runtime patch from gdams from nodejs#29216 (comment) PR-URL: nodejs#31459 Refs: nodejs#29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
PR-URL: nodejs#31459 Refs: nodejs#29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
MylesBorinsforce-pushed the v12.x-notarization branch from f67028d to c5aee86Compare
nodejs-github-bot commented Apr 1, 2020
Backport-PR-URL: #32527 PR-URL: #31977 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Backport-PR-URL: #32527 PR-URL: #32368 Refs: #32296 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. Backport-PR-URL: #32527 PR-URL: #32387 Refs: #32368 Refs: npm/cli#1037 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Backport-PR-URL: #32527 PR-URL: #31459 Refs: #29216 Refs: sindresorhus/macos-terminal-size#3 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
Backport-PR-URL: #32527 PR-URL: #32495 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Includes hardened-runtime patch from gdams from #29216 (comment) Backport-PR-URL: #32527 PR-URL: #31459 Refs: #29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
Backport-PR-URL: #32527 PR-URL: #31459 Refs: #29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
MylesBorins commented Apr 1, 2020
landed in fbd5be6...885c88e Ignoring the linuxone failure as it is infrastructure related and we need to test the notarization stuff |
7 participants
This PR backports the updates of npm to v6.14.4 as well as the build commits to enable 10.15 notarization